dw_dev | Code tour, 26th July 2015

It's time for the code tour bus! Welcome to

sgsabbage (oh wait, that's me!) as first time contributors! I will also be your first time tour guide for this code tour. So, without further ado, on your left you will see...:

Issue 972: Convert rename.tt and rename/swap.tt to Foundation (pull request)
Category: Foundation Conversion
Patch by:

kareila
Description: The conversion to Foundation continues. Foundation is lovely, 'nuff said.

Issue 1046: Convert BML files under htdocs/support (pull request)
Category: BML Conversion
Patch by:

hotlevel4
Description: support/faq.bml is no longer BML. Lowering the average number of BML files (3) on websites, hurrah! The previously quoted "average number of BML files on a website is 3" factoid actualy just statistical error. average website has 0 BML files. Dreamwidt, which lives on a server & has 10,000 BML files, is an outlier adn should not have been counted. (I am not sorry if this joke has been done before)

Issue 1356: OpenID community maintainers are unable to edit tags (pull request)
Category:
Patch by:

kareila
Description: We believe in tag editing equality. This fix means that community maintainers who log in with OpenID can edit tags where they could not previously.

Issue 1374: make two-token rename swap possible independent of which account the tokens are on (pull request)
Category:
Patch by:

kareila
Description: If you want to swap the names of two accounts, it shouldn't matter which account has the rename token. Now as long as between the accounts they have two (or more) rename tokens, it will work!

Issue 1445: entry success page should not show metadata when deleting entry (pull request)
Category:
Patch by:

kaberett
Description: Now when you delete an entry, it will no longer show you additional information about the post that you just deleted.

Issue 1462: angelikitten's Big Eyes mood theme (pull request)
Category:
Patch by:

kareila,

angelikitten
Description: New mood theme, which is

angelikitten's first new mood theme since we transitioned to using git! It is incredibly cute and I might have squeaked just slightly when I first saw it.

Issue 1463: add lj.rossia.org to username tag (pull request)
Category:
Patch by:

pseudomonas
Description: Support for linking to users on lj.rossia.org using site='lj.rossia.org' or site='ljr'. Lovely beans.

Issue 1464: admin tool to reset post-by-email token (pull request)
Category:
Patch by:

pseudomonas
Description: If a spammer gets hold of a user's post-by-email token, it's possible for that spammer to then send in lots of spammy emails. A user can reset this token, but if the user isn't aware this is happening for whatever reason, there's been no way for the site admins to reset the token until now.

Issue 1466: console reference doesn't grey out all unavailable commands (pull request)
Category:
Patch by:

sgsabbage
Description: The console reference page greys out commands you don't have permission to use. Certain commands weren't being greyed out when they were supposed to be. Now they are.

Issue 1497: Whitelist embeds from screen.yahoo.com (pull request)
Category:
Patch by:

sgsabbage
Description: Embedding from screen.yahoo.com is now supported. Here is where I would normally make a 'Yahoo!' joke but that would be terrible and I have a better sense of humour than that.

Issue 1499: Whitelist embeds from ZippCast (pull request)
Category:
Patch by:

sgsabbage
Description: Embedding media from ZippCast is also supported. Yahoo!

Issue 1500: "no text" error on entry posting loses security chosen from dropdown (beta update) (pull request)
Category: New Post Entry Page
Patch by:

kareila
Description: When creating a new post, if you tried to submit it with no text you'd get an error. Unfortunately, if JS was turned on it would also result in your security settings for the post being reverted, which you might miss. Now, the security dropdown will keep whatever setting you had before you attempted to post.

Issue 1502: Timestamp weirdness: multiplying minutes by 100 then truncating causes strange behaviour (pull request)
Category: New Post Entry Page
Patch by:

kareila,

alexseanchai,

exor674
Description: I did not originally understand this bug summary, but I am reliably informed it is the source of some timestamp based weirdness where times such as 12:03 would show up as 12:30 and 12:09 as 13:30 (BECAUSE OBVIOUSLY). This is obviously wrong.

Issue 1504: [Safari+JS] problem with input focus on /rename page (pull request)
Category:
Patch by:

kareila
Description: There was some oddness when trying to click on the "Rename token" field where it wouldn't let you do it in Safari. I was going to make a joke about how the fix is not to use Safari, but I decided that was very mean, and instead the bug was fixed.

Issue 1509: Show name of poster on "Edit tags" page (pull request)
Category:
Patch by:

kaberett
Description: When editing the tags on a community post, it can be handy to see whose post it is. So, now you can.

Issue 1517: include table of contents on faqcat view (pull request)
Category:
Patch by:

sgsabbage
Description: When viewing an FAQ category, now you get a little table of contents before the FAQs with jump-to links. Handy when viewing a large category.

Issue 1518: tidy up payment FAQs a bit
Category:
Patch by:

rahaeli
Description: Some of the FAQs on payment have been tidied up to clarify language and such.

Issue 1523: Possible to see tags used by deleted account (pull request)
Category:
Patch by:

me-and
Description: After an account had been deleted, it was still possible to view the list of tags that they had used when the account was live. This ability has now been removed.

Issue 1524: Remove Select modification level for answer from faqedit (pull request)
Category:
Patch by:

kareila
Description: I did not understand this at all, so I asked the wonderful

kaberett for a translation for me. As it turns out, it had to do with translation. In their words: "So! This one only affected people with the faqedit priv. When editing FAQs, one of the fields you had to fill out was a dropdown describing the "modification level" for the purposes of people who were hypothetically working on translating the site -- so, was the edit a typo in the English (which wouldn't affect the translation), a slight rephrasing without affecting meaning (ditto), or a complete rewrite (which *would* require redoing translation). Dreamwidth is available in English only and there is no intention of providing official translations, so this field being required for editing FAQs was unnecessary, and confusing to new editors."

Issue 1530: Improve code clarity (pull request)
Category:
Patch by:

me-and
Description: Some nice little updates around making the code more readable and standardised when calling certain properties.

Issue 1531: Rewrite README into Markdown (pull request)
Category:
Patch by:

me-and
Description: Github wasn't reading our README as Markdown and so wasn't showing it on the main repository page. This makes it an even better README and means that Github will read it and display it properly.

Issue 1536: Fix uninitialized value warnings (pull request)
Category:
Patch by:

kareila
Description: Some fixes for errors that were showing up on the dreamhacks where values weren't always being initialised properly.

Issue 1539: Display "Default" instead of "All" on navstrip when viewing default reading page (pull request)
Category:
Patch by:

sgsabbage
Description: When viewing your reading page the filter dropdown was incorrectly showing 'All subscriptions' if you were reading your 'Default' filter. Now, it cleverly shows you that you're reading the default filter when you're reading the default filter.

Issue 1542: document some spam prevention suggestions for 'hacks
Category:
Patch by:

rahaeli
Description: Dreamhacks are open to being spammed, so now we have a lovely wiki page (yay wiki pages) to show us how to avoid it where we can. Dreamhack Spam Prevention.

24 total issues resolved
Contributors:

alexseanchai,

angelikitten,

exor674,

hotlevel4,

kaberett,

kareila,

me-and,

pseudomonas,

rahaeli,

sgsabbage