denise: Image: Me, facing away from camera, on top of the Castel Sant'Angelo in Rome (Default)
Denise ([staff profile] denise) wrote in [site community profile] dw_dev2015-01-18 08:30 pm
Entry tags:

Code tour, 11 August 2014 - 17 January 2015

This code tour covers commits from 11 August onward! I may have missed some (it's harder to get a code tour out of Github than it was out of Bugzilla) but I should have most of them. :)

In this code tour, we welcome emhoracek's first contribution! yay! We also welcome [personal profile] azurelunatic's first code patch -- she's been contributing for a while, but this is the first code contribution. Yay!




Issue: #928, slug URLs not accepted everywhere
Patch by: [personal profile] afuna
Description: There were a few spots on the site where using the "slug" (aka the named entry link, aka the thing that lets you name your URL so it's not just numbers) wouldn't work: if you put in (or passed in) the slug as the URL, it would error. This fixes that and now the slug URL should work everywhere except places it would be a serious performance issue.

(If you've ever wondered why that's called a 'slug' -- it's not slug-as-in-mollusc, it's slug-as-in-publishing. It comes from the days of good old-fashioned hot metal type.)


Issue: 934, add "edit entry again" to 'Journal entry was edited' success page
Patch by: [staff profile] denise
Suggested by: [personal profile] katherine
Description: This adds a link to edit the entry again to the page of useful links that get shown when you finish editing an entry.

Issue: 936, Add YouTube as a site recognized by account linking tag
Patch by: [staff profile] denise
Suggested by: [personal profile] caput_mortuum
Description: This adds YouTube as a source for the <user name=foo> linking tag: <user name=foo site=youtube.com> will now work.

Issue: 940, no_mobile cookie not persisting
Patch by: [personal profile] afuna
Description: We forgot to specify an expiration for the cookies we set when you tell the site not to try to use mobile views on a particular device. Without an expiration date, devices were treating the cookie as a session cookie and clearing it when you closed the browser. This adds an expiration date for the cookie for 10 years in the future, which should help it persist.

Issue: 942, convert entry/new to Foundation
Patches by: [personal profile] afuna
Description: This converts the update page to using Foundation, the new web framework we're using.

Issue: Add npr.org to embed whitelist
Patch by:
[personal profile] hotlevel4
Description: This will allow users to embed widgets from npr.org.

Issue: 943, add intra-tag navigation links
Patch by: [personal profile] woggy
Suggested by: [personal profile] fiddlingfrog
Description: Have you ever been looking at a particular entry from somebody and noticed that it's tagged with something (let's say, 'cats') and you want to find the next entry of theirs tagged with 'cats' so you can just keep reading through that tag? Thanks to [personal profile] woggy, now you can.

Issue: 950, make /htdocs/admin/theschwartz use table prefix
Patch by: [personal profile] pauamma
Description: There was a very old bug in that page in which database lookups were not being done quite right! Now they are.

Issue: 825, make rename tokens independent of account
Patch by: [personal profile] pauamma
Description: We originally (for security and to make sure that rename tokens couldn't be misused) made it so that you had to buy the rename token on the account you wanted to rename, and couldn't use a rename token issued to Account A to rename Account B. Turns out that's not how people tend to use tokens in practice, and it got gnarly enough with me having to keep explaining this to people (or creating new rename tokens for them) and all, so now you can just use a rename token on any account by typing it in.

Issue: 710, warn people when they did not assign keywords to icons
Patch by: [personal profile] hotlevel4
Description: If you don't add keywords to your icons, they get an automatic fallback keyword (of the form 'pic###'). Those automatic fallback keywords behave very strangely from time to time, and while we've been trying to fix those bugs, the icon code is among the oldest code on the site and it's got tendrils everywhere -- things have proven very hard to fix. So, while we beat our heads against those problems, we'll also warn you that things will work a LOT better if you keyword your icons.

Issue: 742, screened comment text slightly inaccurate still in comms
Patch by: [personal profile] hotlevel4
Description: We've been trying to make sure that all the text on the site is accurate, in terms of who can see what. We discovered that the "your comment has been screened" text when you post a screened comment was missing one person on the "who can see your comment" list -- namely, if a screened comment is in reply to another screened comment, the person who made the comment you're replying to can see it. So, this adds that to the message.

Issue: 728, Use language for community on /manage/settings/?cat=display (Entry Style and Icon Style options)
Patch by: emhoracek (First contribution! Welcome!)
Description: This fixes the wording on a few of the settings when you're managing a community's settings, not your individual account. (There were a few items that needed to be described slightly differently for a community.)

Issue: 906, lack of confirmation when commenting anon in a community where anon comments are screened
Patch by: [personal profile] hotlevel4
Description: Thanks to a single missing . (no, really), the "your comment has been screened" message was not displaying properly when an anonymous comment was made in a place where anon comments were being screened. (I love single character bugfixes. I really do.)

Issue: 826, make admin tool to revoke rename tokens
Patch by: [personal profile] pauamma
Description: This is connected to the "let rename tokens be used by typing them in directly" thing: I also needed a way to revoke rename tokens entirely, so that if someone reported fraud, issued a credit card chargeback, etc, etc, I could revoke the token.

Issue: 963: Convert htdocs/support/submit.bml and associated widget to use TT and a controller
Patch by: [personal profile] pauamma
Description: This converts the page where you can submit a support request to our new way of generating pages.

Issue: 977, Enable non-logged-in users to post from the new entry page
Patch by: [personal profile] afuna
Description: It's possible to use the old update page while you're not logged into your account -- you can write your entry, and then give your username and password at the time you post it. This adds that functionality to the new update page as well!

Issue: 984, perldoc and DW::FormErrors don't play nice
Patch by: [personal profile] pauamma
Description: Bugfix to correct a problem with the inline comments not properly generating the Perl documentation file.

Issue: 986, create errors component which accepts DW::FormErrors objects
Patch by: [personal profile] afuna
Description: There are umpty different ways in our codebase to display errors to you! Sadly, we had to add another one, but that's okay, because this is the one that everything else is going to eventually use.

Issue: 982, update list of TLDs accepted in email addresses
Patch by: [personal profile] afuna
Description: There have been a lot more TLDs (top level domains) added since we started this whole thing! The "does that look like a valid email address" checker was just looking for the previous ones, like .com and .org and .net and the like. This adds in all the others, however unlikely we think it is that someone will try to use a .blackfriday email address while signing up for the site.

Issue: 1009, finish stripping /admin/impersonate
Patch by: [personal profile] pauamma
Description: This gets rid of more hardcoded English, this time in admin files.

Issue: 965, Create front end UI for creating/updating a support cat
Patch by: [personal profile] pauamma
Description: Occasionally we need to create a new support category, or change the settings on an old one, and previously the only way to do that was by directly querying the database or running a SQL statement against the database. This adds a frontend interface to that.

Issue: 1024, DW::Template::Plugin::FormHTML POD has errors
Patch by: [personal profile] pauamma
Description: This fixes more issues with the documentation that's automatically generated from the in-code comments.

Issue: 1026, DW::Template::Plugin::FormHTML::textbox not handling aria-describedby correctly
Patch by: [personal profile] pauamma
Description: The code to create a textbox was adding in the WAI-ARIA label description too far down in the code for it to be useful, so it wasn't appearing properly in the output HTML. This moved it up further in the code so it will actually do some good.

Issue: 1029, Convert htdocs/go.bml from BML
Patch by: [personal profile] afuna
Description: More converting the old way of doing things to the new way. (You use this page every time you hit the previous or next link on the menu bar on top of entries; you just don't know that you use it. Heh.)

Issue: 1037, DW::FormErrors displays error message string keys instead of actual text
Patch by: [personal profile] pauamma
Description: The error-message-displayer was displaying the wrong thing -- now it displays the actual error message.

Issue: 1048, Prevent caching on some pages once converted
Patch by: [personal profile] afuna
Description: During part of the conversion from BML to TT & Foundation, we realized we hadn't specified a way to ask the browser not to cache that particular page. (We had that available in the old BML version of things.) Since sometimes there are pages that shouldn't be cached -- they change each time you load them, or you need them to be absolutely fresh data -- we implemented that here as well.

Issue: 1050, Convert community membership request /approve and /reject
Patch by: [personal profile] afuna
Description: More conversion to TT and Foundation.

Issue: 1047, Convert BML files under htdocs/tools
Patch by: [personal profile] afuna
Description: More conversion to TT and Foundation. This is all stuff that you will see rarely.

Issue: 1039, Investigate whether we can delete directorysearch endpoint and directorysearch*.js
Patch by: [personal profile] afuna
Description: More stuff we can get rid of!

Issue: 1041, Investigate whether we can delete multisearch endpoint
Patch by: [personal profile] afuna
Description: Yet more stuff we can get rid of.

Issue: 1042, Investigate whether we can delete misc endpoint files
Patch by: [personal profile] afuna
Description: If you guessed this is more stuff we can get rid of, you're right.

Issue: 1058, convert miscellaneous BML
Patch by: [personal profile] afuna
Description: converts /beta, /accountstatus, /changepassword, tools/embedcontent, the 404s.

Issue: 1044, Convert BML files under htdocs/admin
Patch by: [personal profile] afuna
Description: converts various BML files under the /admin path. This is generally stuff you'll never see.

Issue: 1062, DW::Controller::Admin::ThemeMetadata has inconsistent header
Patch by: [personal profile] pauamma
Description: Fixes the in-code header to be the correct file path.

Issue: 948, possible to open a support req without associated email address
Patch by: [personal profile] pauamma
Description: It's possible to open a support request when not logged in. This is a good thing! It lets people open requrests without having an account, or without being able to log into their account. On the other hand, the "create a support request" form didn't require an email address -- it only allowed you to specify one. So it was possible to submit a support request without an email address, while logged out: in other words, it was possible to make it impossible for anyone to reply to you. (If the request stayed in public support, there was a chance whoever opened it would come back and check on it, if they'd bookmarked it, but if their request had to go into a private category, it would never be possible to go back to it again.) So, now anyone opening a support request while logged out will be required to specify an email address.

Issue: 1065, Librarians Dream / Battle Raven - Missing background
Patch by: [personal profile] baggyeyes
Description: This fixes a missing image from the Battle Raven theme for Librarian's Dream.

Issue: 1061, Convert /manage/circle/add, /community/join, /community/leave from BML
Patch by: [personal profile] afuna
Description: This takes three separate pages and turns them all into the same page, thanks to the magic of magic. The redesigns on this one are particularly gorgeous!

Issue: 1035, Convert misc BML pages in htdocs/tools/endpoints
Patch by: [personal profile] afuna
Description: More conversion! This is all stuff you will never see.

Issue: 1071, Make instant purge possible on dev instances
Patch by: [personal profile] pauamma
Description: It's hard to test things having to do with expunged (purged) accounts on your development machine when it's really hard to expunge a user without waiting for the time to pass! This makes it possible to expunge an account immediately without the wait.

Issue: 1053, Automatically create an id for form elements with no id but with label
Patch by: [personal profile] afuna
Description: Fixes a problem where sometimes a HTML form element could be created with a label but without an id, which would cause problems with displaying the label in some browsers.

Issue: 1078, reply from the read page, without a new page load
Patch by: [personal profile] afuna
Description: This adds the ability to reply to entries directly from your reading page by clicking the 'reply' link. (If you want to read existing comments before adding your own, click the 'Read X comments" link.)

Issue: 842, Update/Expand list of available locations on profile
Patch by: [personal profile] pauamma
Description: A while back, we started talking about updating the country list, which hadn't been touched since 2000 or so. The question of what data source to use (and what to do with countries that aren't listed in that data source, but that people feel are nation-level entities anyway) is something we've been talking about for a very long time, and we never really came up with a good answer. Instead of coming up with the answer ourselves, we punted: we've switched to using the Locale::Codes::Country module, so that someone else can have the hard questions!

Issue: 1086, views/shop/icons.tt and views/shop/points.tt have unclosed strong tags
Patch by: [personal profile] pauamma
Description: Adds in some missing HTML tags.

Issue: 1090, convert create page
Patch by: [personal profile] afuna
Description: Converts the create-an-account workflow to TT/Foundation.

Issue: 1097, Add github to <user name="" site=""> possibilities
Patch by: [personal profile] azurelunatic
Description: Allows people to link to Github usernames with the user name tag.

Issue: 1101, Whitelist embeds from imgur
Patch by: [personal profile] hotlevel4
Description: This will whitelist widgets from imgur, letting you put albums in your posts.

Issue: 1103, Fixes to converted embed
Patch by: [personal profile] afuna
Description: This tweaks embedded widgets to prevent problems with display.

Issue: 1112, when width/height units are mismatched, embed height is not correct
Patch by: [personal profile] afuna
Description: And more fixes to embedded widgets to prevent display problems.



Pull requests/bugfixes with no associated issues:

PR: Use style_opts instead of style_args in the entry url
Patch by: [personal profile] afuna
Description: Fixes a bug where URLs were created from the wrong variables.

PR: Get rid of horizontal scrollbar
Patch by:
[personal profile] afuna
Description: Fixes a bug where people using the Celerity site skin on small screens would get a horizontal scrollbar where they shouldn't.

PR: Tweak whitespace for queues (used in moderation entry queue)
Patch by: [personal profile] afuna
Description: Tweaks the display of items showing in the moderation queue for the community management area

PR: Adds journal sub+title to beta update previews
Patch by: [personal profile] kaberett
Description: Fixes a bug where if you were using the beta update page, previewing the entry you were writing would show the wrong thing: instead of the journal title/subtitle (which is what would show once the entry was posted), it was showing the user's display name. This fixes that!

PR: Replace CRLF with LF
Patch by: [personal profile] afuna
Description: This is pretty much inside baseball, but: some computers/text editors use one kind of line breaks, and some use the other kind. We try to make sure that people contributing to the code have their computer set to use the kind we've standardized on, but sometimes we miss them, so we occasionally go through and fix them in bulk.

PR: Make the last delay happen in 10 seconds rather than 0
Patch by: [personal profile] afuna
Description: If we can't get a captcha from our captcha service, the task that fetches more of them slowly backs off so it doesn't overwhelm the service's servers. This changed the last length of time it waits until failing ...

PR: Undo "fix" of captcha task
Patch by: [personal profile] afuna
Description: ...except it turns out that the last value does have to be 0, not 10 seconds, so that it stops retrying after it's failed enough times. Oops. :)

PR: Remove some unused files
Patch by: [personal profile] afuna
Description: Every time we think we've found all the old stuff we don't need anymore and gotten rid of it, we find some more. This gets rid of more of it. :) (At least by now we've moved on to getting rid of stuff that we added to the code that we don't need anymore, instead of stuff that was there when we forked the code that we don't need anymore!)

PR: Further tweaks to /entry/new and /entry/edit
Patch by: [personal profile] afuna
Description: Miscellaneous bugfixes and display fixes for the Foundation conversion of the update page.

PR: Convert some files in htdocs/misc
Patch by: [personal profile] afuna
Description: More "get rid of BML, change things to the new way of doing things".

PR: Convert misc BML files in tools/endpoints
Patch by: [personal profile] afuna
Description: Yet more "get rid of BML"!

PR: Update to Foundation 5.4.7
Patch by: [personal profile] afuna
Description: Updates the version of Foundation being used.

PR: remove redundant use controller lines
Patch by: [personal profile] afuna
Description: Removes an accidental duplicated line.

PR: Make consistent creating of the authas form
Patch by: [personal profile] afuna
Description: This fixes a thing where there were multiple ways of putting together authas (the thing where you can work as another user on a particular page).

PR: Make sure we include jquery ui theme for journal pages
Patch by: [personal profile] afuna
Description: Make sure that the Jquery library gets loaded in all the places it should be loaded.
azurelunatic: A glittery black pin badge with a blue holographic star in the middle. (Default)

[personal profile] azurelunatic 2015-01-18 07:44 am (UTC)(link)
I am delighted by the thought that there will be more of me on this site!

[personal profile] swaldman 2015-01-18 10:19 am (UTC)(link)
Great to see new contributors!
(and, possibly the first time I've seen a code tour include a patch by somebody with a deleted account.....)
nou: The word "kake" in a white monospaced font on a black background (Default)

[personal profile] nou 2015-01-18 10:44 am (UTC)(link)
The fix to #934 makes me very happy, thank you!
brainwane: My smiling face, including a small gold bindi (Default)

[personal profile] brainwane 2015-01-18 01:19 pm (UTC)(link)
Pretty cool stuff!
woggy: (Flower Frog)

[personal profile] woggy 2015-01-18 04:15 pm (UTC)(link)
yaaaaaaaaay it's a code tour! :D
baggyeyes: Photo.1946 Ann. 4x5 Speed Graphic (Photo.1946 Ann. 4x5 Speed Graphic)

[personal profile] baggyeyes 2015-01-18 05:27 pm (UTC)(link)
Bug 1065 - Librarian's Dream missing image, is mine. Sorry about the confusion.
baggyeyes: Princess Leia (Default)

[personal profile] baggyeyes 2015-01-19 02:43 pm (UTC)(link)
My Github profile doesn't say anything about Baggyeyes. So let's blame Github. :)
katherine: Girl with glasses: Fuzzy cat with a folded pair of glasses by her paw. (Default)

[personal profile] katherine 2015-01-18 07:13 pm (UTC)(link)
Issue: 934, add "edit entry again" to 'Journal entry was edited' success page

I just squeaked out loud excitedly.
cesy: "Cesy" - An old-fashioned quill and ink (Default)

[personal profile] cesy 2015-01-19 03:28 pm (UTC)(link)
I am glad to see all the technical debt paydown in here, cleaning out old stuff and converting BML to TT.