Code tour: 24th March--11th April

[kaberett]

All aboard the code train! Today we'll be stopping at 12 stations...


Bug 2908: remember "send me a copy of my own message" selection for next time
Category: Inbox/Notifications
Suggested by: the_shoshanna
Patch by: purplecat
Description: Our first stop is purplecat's first patch! We'll be pausing here for a little longer than usual, in order to bring out the cake and the party streamers and do a little dance. The patch in question is a neat little trick: when sending PMs, the system automagically remembers whether or not you ticked "send me a copy" on the previous occasion you messaged someone. Alas, this does mean fewer excuses to play with tickyboxes, but it hopefully also means fewer messages lost forever in the ether.

Bug 4066: Imports show up as "aborted" when we're processing previous imports
Category: Importer
Patch by: fu
Description: Attention please: trying to run two imports at once is about as bad a plan as trying to board two trains at once, in that the second import you schedule will fall over and die. (Okay, maybe this is a bad metaphor.) However! Once this patch goes live, rather than simply being told your new import has aborted, you'll be told that it's failed because you've already got an import processing.

Bug 2234: add system notices filter to inbox
Category: Inbox/Notifications
Patch by: ninetydegrees
Description: Your message inbox already contained the options to filter by a number of categories: direct messages to you, birthdays, notifications regarding entries and comments, etc. At this station we'll be restocking the buffet trolley... with a "system notices" filter that will show you only messages relating to crosspost notifications, community invitations, news posts, import status updates, acceptance of vgifts, and notifications about expunged accounts. And a tasty little platter it is too. :-)

Bug 4109: strip trailing spaces in sysban creation
Category: Site Administration
Patch by: randomling
Description: Another lengthy stop while we celebrate randomling's first patch! Another dance, please! Balloons, maybe? Taking over household chores? Something like that, anyway. Once this darling goes live, you'll never be ambushed by pesky trailing spaces ever again while setting up new sysbans.

Bug 4387: (jquery beta) thread expander slow; leads to unresponsive script errors
Category: Journal contents
Patch by: allen
Description: ... and from here on out there's been a track upgrade, so we'll be running faster & smoother. Some users had been experiencing unresponsive script errors when hitting "Expand All". The general consensus was Down With That Sort Of Thing - so the error shouldn't keep popping up, and hopefully people will notice long threads loading a little quicker!

Bug 4371: Rainbow Child mood theme, by angelikitten
Category: Misc UI/Frontend
Patch by: exor674, using angelikitten's images
Description: A shiny new moodtheme! Non-animated faces with rainbow hair.

Bug 4276: Screened comments in site skin are indistinguishable
Category: Misc UI/Frontend
Patch by: momijizukamori
Description: This fix means we'll be using a darker, somewhat flatter, background gradient for screened comments in Gradation - making them much more visually distinct than they are currently. You might already have noticed some components of this fix, which went live in the last push - the styling's also now clearer for Tropo Red and Tropo Purple (Lynx and Celerity stylings already made things nice and clear). Thanks, Momiji!


Bug 4394: Minor CSS tweaks/bugfixes for Marginless
Category: Style System
Patch by: momijizukamori
Description: The style (or is that station) Marginless used to contain a few infelicities. Happily, recent renovations will soon be on view to the public (albeit only those of them that go looking): there's now a manage icons link on user-styled icons pages; the search bar no longer overflows the side bar; and we now get the nav strip in header and one-column modes. These changes should be mostly invisible!

Bug 4384: Marginless: sort and rephrase custom props
Category: Style System
Patch by: ninetydegrees
Description: Extra colour options have been sorted into appropriate categories and given new descriptions using standard phrasing. It's a bit like finally getting a map put in at the entrance to the station, really.

Bug 3172: Add a .no-title class if an entry/comment doesn't have a title
Category: Style System
Patch by: ninetydegrees
Description: This change makes it easier for people to avoid showing empty title boxes, if they so wish! It works for both comments and entries; it doesn't interfere with 'invisible' titles implemented for screen readers; and it's been tweaked so it should play nicely with all styles. Yay!

Bug 4375: Crossroads: new themes
Category: Style System
Patch by: delladea
Description: 9 new themes for the style Crossroads! Six were put together by nornoriel: Loveless, Battle Raven, Andúnë, Winter Court, Marry The Night and Sweetness. Three were by momijizukamori: Reaper, Archer, and Healer.


Bug 4038: New Style: Line Up by timeasmymeasure
Category: Style System
Patch by: ninetydegrees
Description: ... and to continue the trend of making things prettier, the final fix of this tour also relates to all things bright and beautiful: one new style by timeasmymeasure has been implemented, with one theme: it's called "Line Up".



This train terminates here. Thank you for travelling with dw_dev; we hope you enjoyed your journey, and we trust we'll see you again soon. All change please.

Comments

[musyc]

Bug 2908: remember "send me a copy of my own message" selection for next time

*whimpers with relief* That was actually irritating the heck out of me earlier today. Serendipity that it's patched now. Huzzah!

Bug 4387: (jquery beta) thread expander slow; leads to unresponsive script errors

*even more whimpering with relief* Yayyyyyyyyyyyyyyy. Happy to see this getting fixed.

[azurelunatic]

Hooray!!!

[poulpette]

Great tour!
Bug 4038: New Style: Line Up by timeasmymeasure
\o/ This style is gorgeous:)

(You've got a hitchiker problem on Bug 4375: 3 extra themes are squatting nornoriel's Crossroads compartment. )

[kaberett]

Thank you - I've booted them off :D

[ex_mrs260625]

Rainbow Child mood theme, by angelikitten

I've never updated my mood theme before, but these are really cute! I think I'll give them a go when the code push goes live.

[angelikitten]

Thank you!

[momijizukamori]

Two comments on my bugs *g* - for 4276, there's actually Tropo Purple and Red components (Lynx and Celerty already styled them differently) that got pushed in the previous push, but didn't make codetour because the bug itself wasn't closed - Tropo Red uses a muted red comment header, and Tropo Purple, a muted purple.

For 4394, hopefully these will be invisible bugfixes for the most part! (except the search bar thing, that was driving me crazy). They mostly concerned the still-not-live user-styled icon page, and some bugs under a very specific combination of settings, which weren't the default.

[kaberett]

kcool! I got a bit overwhelmed by the comment thread on that bug, presumably because of ^this, and I think you were offline at the time. I should presumably edit these bits in?

[momijizukamori]

I... have no idea. I am not wise in the way of the code tour

[kaberett]

AUGH

will ask mama rah when I next catch her online :-)

[kaberett]

She Upon High sez yes, and the changes have now been edited in.