Entry tags:
Code Tour, December 8-23 2011
Two new code-bus drivers, this week, me (
ghoti) and
brainwane. Keep all appendages inside the bus, and as you exit the vehicle, please lower your head and watch your step. If you fail to do so, please lower your voice and watch your language.
Bug 4080: DW::Template::Filters thinks it's DW::Template::Plugin
Category: Routing/TT
Patch by:
fu
Description: There was duplication in header comments. Now there's not.
Bug 4105: Bugzilla "Your Bugzilla bug list needs attention." uses improper terminology
Category: General/Unknown
Patch by:
mark
Description: So when Bugzilla updated to version 4.0 they changed the existing statuses (states? stati?) to be UNCONFIRMED (new bugs), CONFIRMED (yes, this is a valid bug), IN_PROGRESS (working on it), RESOLVED (same), and VERIFIED (resolution is valid). Mark updated our stuff to match theirs, except that we won't use "verified".
Bug 4108: "$r->post_args || $r->get_args" construct longer works
Category: Misc Backend
Patch by:
fu
Description: To quote
denise, this is some "backend voodoo" to fix a glitch in how pages are built.
Bug 4110: New icon browser chokes on icon keywords and alt text that look like numbers
Category: Misc UI/Frontend
Patch by:
fu
Description: Numbers in the alt text for an icon (that's the hover text for screenreaders and things) need to be changed to strings, so
fu forced the text to have quotation marks to avoid the choking in the future.
Bug 3944: Dusty Foot: new themes
Category: Style System
Patch by:
ninetydegrees
Description: New shiny!
Six themes for Dusty Foot by
timeasmymeasure: Alive, Bold Dances, Did It Again, Emerging Discoveries, Heartwarming, Realizations.
Nine themes by
nornoriel: Andune, Decadence, Dusk, Enchanted Forest, Fey Frolic, Juno, Loveless, Misty Wood, Winter Court.
A whopping fourteen (14!!!) themes by
rising: Monochrome Brown, Monochrome Purple, Ombre, Raspberry Kiss, Zoned. (Now with Bonus! Header! Textures!): Argyle, Blue Days, Certain Frogs, Dependable, Elegant BRown, El mar, Radiant, Rocket, Stranger Days.
Bug 4045: Styles: Remove CSS resets
Category: Style System
Patch by:
ninetydegrees
Description: Mucked around with some CSS settings that were removing padding and margins, and now we're (hopefully) seeing fewer side effects. Fewer side effects = happier everyone! Changes were applied to the following layouts: Practicality, Compartmentalize, Crisped, and Five AM.
Bug 4113: user mover/purge script needs updating
Category: Site Administration
Patch by:
mark
Description: There were old tables rusting and rotting in the background of this script. Mark dropped the tables and polished things up and now they're running happily.
Bug 4115: Protected entries in search show up as deleted
Category: Search
Patch by:
fu
Description: More backend weevils. When search was trying to check whether the user doing the search can see an entry, search doesn't know who is doing the search, so protected entries weren't showing up. Now search will check other settings instead of who the user is.
Bug 4102: Checkboxes to retain relationships when renaming have disappeared
Category: Misc Backend
Patch by:
denise and
fu
Description: So when you rename your account, you're supposed to get checkboxes that keep your access list, filters, and stuff like that during the rename. Unfortunately those checkboxen had disappeared. This shouldn't happen anymore. If you got caught in this bug, please tell
denise or
fu.
Bug 4125: "Invite someone" link displayed even when we have invite codes turned off
Category: Misc UI/Frontend
Patch by:
fu
Description: Will only show the link to invite someone if we need it. Until the end of this year (9 shopping days left in 2011!) you won't see the invite link. Create a new account here.
Bug 4122: Polls: [+] in View Respondents doesn't work
Category: Misc UI/Frontend
Patch by:
fu
Description: Typo in the javascript. Fixed now.
Bug 4100: Strip Talk.pm entirely
Category: English-Stripping
Patch by:
ninetydegrees
Description: More English-stripping, this time from the comment form.
Bug 4098: 'Anonymous' color hardcoded in the source in Reply form
Category: Style System
Patch by:
ninetydegrees
Description: When a commenting option is disabled, it used to be grayed out for everyone. Depending on your theme, it was very difficult to see this gray. Now it's not gray for everyone. Also, there was a renegade font tag which is no longer there.
Bug 4131: "Icon" link in "Icon to use" in quick reply not aligned with the rest of the text
Category: Misc UI/Frontend
Patch by:
fu
Description: Made things line up all pretty and organized-like.
Bug 4111: FAQ 87 needs more sites on the list
Category: User documentation
Patch by:
denise
Description: Added a list to the FAQ for which sites get an icon before the user name.
Bug 4073: Site search retains deleted content
Category: Search
Patch by:
fu
Description:
ninetydegrees was doing a site search and got a result from a deleted journal. That ... is not an ideal situation. This patch adds a filter to indicate when the journal is not visible and won't show it as part of the results. It also manages to zap another bug in the process. Yay bug zapping!
Bug 4135: quick sanity checks for suggestions generator
Category: Site Administration
Patch by:
denise
Description: There has been an uptick in spam in Suggestions, so this patch will interrupt the suggestion process if the account making the suggestion isn't validated or if it's been suspended.
Bug 4128: Add header background images to Sunday Morning
Category: Style System
Patch by:
foxfirefey
Description: Even more shiny! Adds a header image option, and tweaks various other things to accommodate the header if given.
Bug 4064: Some spam report views display header line as HTML <title> instead of body <h1>
Category: Misc UI/Frontend
Patch by:
fu
Description: Took the HTML out of the window title.
Bug 1044: add warning when buying paid time for a deleted account
Category: Payments
Patch by:
fu
Description: If an account is deleted, and you try to buy paid time for it, you will be warned and will have to resubmit to say that yes, you *do* want to do that.
fu was extra nice and told the form to remember what you've entered so you won't have to do that part again.
Bug 4134: suggestions generator needs to check for valid post before posting admin entry
Category: Site Administration
Patch by:
fu
Description: So a side effect of the spam-fest in Suggestions was that about a bazillion and three admin entries were created. Now an admin entry will only be created if the first user-submitted entry was posted successfully.
Bug 750: Can't choose non-US country with state
Category: Misc UI/Frontend
Patch by:
fu
Description: Users in Canada, Australia, and sometimes the UK were getting an error when trying to enter their state in their profile, namely that they had entered both "US" for their country and a non-US state in the "other state" field.
fu changed things so that "states/regions/territories" is cleared if it actually manages to save.
Bug 4138: Site Skin description: incorrect info for Tropo skins
Category: Site Layout/Navigation
Patch by:
fu
Description: We can math. The font is 75% the size of the browser default, not 25%. It's smaller, but not *that much* smaller.
Bug 4129: Customize Wizard: font field not big enough
Category: S2 Backend
Patch by:
ninetydegrees
Description: If you wanted to enter three font names when customizing your journal, you may have run out of room. Now the field is twice as large and will hold twice as many characters (50 vs 25).
Bug 3607: Redesign profile edit page to not be so wide on the main site
Category: Misc UI/Frontend
Patch by:
denise
Description: There was a long and wordy explanation that was making the page wider than it may have otherwise been. Now the explanation has been moved, and the page is more reasonably wide.
Bug 3816: indicate which support categories are private cats
Category: Site Administration
Patch by:
fu
Description: Most support requests are visible to everyone, so everyone can help answer them. For privacy, only Dreamwidth staff and trusted volunteers can see support requests in certain categories, like Account Payments issues or Terms of Service violations. But that wasn't clear to regular users on the support ticket submission page. Now it is, because there are asterisks marking those categories.
Bug 3087: Need method to get keyword from kwid
Category: Misc Backend
Patch by:
fu and
kareila and
exor674
Description: This was a request for some backend cleanup so that developers working with interests could just look for the interests' unique ID numbers in one place, instead of having to look for it in multiple places. This got fixed a while ago with another bug (possibly Bug 3064 or Bug 1776), and nobody noticed that we could close this ticket until just now.
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Bug 4080: DW::Template::Filters thinks it's DW::Template::Plugin
Category: Routing/TT
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: There was duplication in header comments. Now there's not.
Bug 4105: Bugzilla "Your Bugzilla bug list needs attention." uses improper terminology
Category: General/Unknown
Patch by:
![[staff profile]](https://www.dreamwidth.org/img/silk/identity/user_staff.png)
Description: So when Bugzilla updated to version 4.0 they changed the existing statuses (states? stati?) to be UNCONFIRMED (new bugs), CONFIRMED (yes, this is a valid bug), IN_PROGRESS (working on it), RESOLVED (same), and VERIFIED (resolution is valid). Mark updated our stuff to match theirs, except that we won't use "verified".
Bug 4108: "$r->post_args || $r->get_args" construct longer works
Category: Misc Backend
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: To quote
![[staff profile]](https://www.dreamwidth.org/img/silk/identity/user_staff.png)
Bug 4110: New icon browser chokes on icon keywords and alt text that look like numbers
Category: Misc UI/Frontend
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: Numbers in the alt text for an icon (that's the hover text for screenreaders and things) need to be changed to strings, so
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Bug 3944: Dusty Foot: new themes
Category: Style System
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: New shiny!
Six themes for Dusty Foot by
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Nine themes by
![[profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
A whopping fourteen (14!!!) themes by
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Bug 4045: Styles: Remove CSS resets
Category: Style System
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: Mucked around with some CSS settings that were removing padding and margins, and now we're (hopefully) seeing fewer side effects. Fewer side effects = happier everyone! Changes were applied to the following layouts: Practicality, Compartmentalize, Crisped, and Five AM.
Bug 4113: user mover/purge script needs updating
Category: Site Administration
Patch by:
![[staff profile]](https://www.dreamwidth.org/img/silk/identity/user_staff.png)
Description: There were old tables rusting and rotting in the background of this script. Mark dropped the tables and polished things up and now they're running happily.
Bug 4115: Protected entries in search show up as deleted
Category: Search
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: More backend weevils. When search was trying to check whether the user doing the search can see an entry, search doesn't know who is doing the search, so protected entries weren't showing up. Now search will check other settings instead of who the user is.
Bug 4102: Checkboxes to retain relationships when renaming have disappeared
Category: Misc Backend
Patch by:
![[staff profile]](https://www.dreamwidth.org/img/silk/identity/user_staff.png)
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: So when you rename your account, you're supposed to get checkboxes that keep your access list, filters, and stuff like that during the rename. Unfortunately those checkboxen had disappeared. This shouldn't happen anymore. If you got caught in this bug, please tell
![[staff profile]](https://www.dreamwidth.org/img/silk/identity/user_staff.png)
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Bug 4125: "Invite someone" link displayed even when we have invite codes turned off
Category: Misc UI/Frontend
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: Will only show the link to invite someone if we need it. Until the end of this year (9 shopping days left in 2011!) you won't see the invite link. Create a new account here.
Bug 4122: Polls: [+] in View Respondents doesn't work
Category: Misc UI/Frontend
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: Typo in the javascript. Fixed now.
Bug 4100: Strip Talk.pm entirely
Category: English-Stripping
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: More English-stripping, this time from the comment form.
Bug 4098: 'Anonymous' color hardcoded in the source in Reply form
Category: Style System
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: When a commenting option is disabled, it used to be grayed out for everyone. Depending on your theme, it was very difficult to see this gray. Now it's not gray for everyone. Also, there was a renegade font tag which is no longer there.
Bug 4131: "Icon" link in "Icon to use" in quick reply not aligned with the rest of the text
Category: Misc UI/Frontend
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: Made things line up all pretty and organized-like.
Bug 4111: FAQ 87 needs more sites on the list
Category: User documentation
Patch by:
![[staff profile]](https://www.dreamwidth.org/img/silk/identity/user_staff.png)
Description: Added a list to the FAQ for which sites get an icon before the user name.
Bug 4073: Site search retains deleted content
Category: Search
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Bug 4135: quick sanity checks for suggestions generator
Category: Site Administration
Patch by:
![[staff profile]](https://www.dreamwidth.org/img/silk/identity/user_staff.png)
Description: There has been an uptick in spam in Suggestions, so this patch will interrupt the suggestion process if the account making the suggestion isn't validated or if it's been suspended.
Bug 4128: Add header background images to Sunday Morning
Category: Style System
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: Even more shiny! Adds a header image option, and tweaks various other things to accommodate the header if given.
Bug 4064: Some spam report views display header line as HTML <title> instead of body <h1>
Category: Misc UI/Frontend
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: Took the HTML out of the window title.
Bug 1044: add warning when buying paid time for a deleted account
Category: Payments
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: If an account is deleted, and you try to buy paid time for it, you will be warned and will have to resubmit to say that yes, you *do* want to do that.
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Bug 4134: suggestions generator needs to check for valid post before posting admin entry
Category: Site Administration
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: So a side effect of the spam-fest in Suggestions was that about a bazillion and three admin entries were created. Now an admin entry will only be created if the first user-submitted entry was posted successfully.
Bug 750: Can't choose non-US country with state
Category: Misc UI/Frontend
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: Users in Canada, Australia, and sometimes the UK were getting an error when trying to enter their state in their profile, namely that they had entered both "US" for their country and a non-US state in the "other state" field.
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Bug 4138: Site Skin description: incorrect info for Tropo skins
Category: Site Layout/Navigation
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: We can math. The font is 75% the size of the browser default, not 25%. It's smaller, but not *that much* smaller.
Bug 4129: Customize Wizard: font field not big enough
Category: S2 Backend
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: If you wanted to enter three font names when customizing your journal, you may have run out of room. Now the field is twice as large and will hold twice as many characters (50 vs 25).
Bug 3607: Redesign profile edit page to not be so wide on the main site
Category: Misc UI/Frontend
Patch by:
![[staff profile]](https://www.dreamwidth.org/img/silk/identity/user_staff.png)
Description: There was a long and wordy explanation that was making the page wider than it may have otherwise been. Now the explanation has been moved, and the page is more reasonably wide.
Bug 3816: indicate which support categories are private cats
Category: Site Administration
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: Most support requests are visible to everyone, so everyone can help answer them. For privacy, only Dreamwidth staff and trusted volunteers can see support requests in certain categories, like Account Payments issues or Terms of Service violations. But that wasn't clear to regular users on the support ticket submission page. Now it is, because there are asterisks marking those categories.
Bug 3087: Need method to get keyword from kwid
Category: Misc Backend
Patch by:
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
Description: This was a request for some backend cleanup so that developers working with interests could just look for the interests' unique ID numbers in one place, instead of having to look for it in multiple places. This got fixed a while ago with another bug (possibly Bug 3064 or Bug 1776), and nobody noticed that we could close this ticket until just now.
no subject
I totally read that as have private cats, and all I could think was that my cats SUCK at being private. Aloof and independent animals, HA HA HA HA HA.
no subject
no subject
Stupid spammers.
no subject
no subject
(Proud reporter of #4129)
no subject
no subject