3 Issues - Entry Posting & Cross-posting

[jimmyb]

So I finally started to play around with my DW-install and I've come across 3 issues so far.


Upon visiting http://www.mysite.com/manage/circle/add.bml?user=USERNAME or http://www.mysite.com/manage/circle/ you get the following error:

[Error: Invalid type 'Q' in pack at /home/dw/cgi-bin/DW/User/Edges/WatchTrust/Loader.pm line 276. @ deathnote]

The line previously read:

my $packfmt = "NH6H6QC"; # pack format

Changed to:

my $packfmt = "NH6H6NC"; # pack format

Now I really have no idea how the packfmt works, but changing the Q to an N fixes the issue...so maybe someone couple explain what it is, and how it works, and what the letters mean? And why using N fixes it...


When submitting a new entry, an error message came up. The entry still posts, but tags are not included in the new entry. Line 1492 in cgi-bin/LJ/Entry.pm.

The line previously read:

$row = pack("NNNQN", $item->{'posterid'}, $eventtime, $logtime, $sec,

Changed to:

$row = pack("NNNNN", $item->{'posterid'}, $eventtime, $logtime, $sec,

Again, another pack issue, and changing the Q to an N fixes the issue.

I setup my account to cross-post to Scribbld and when I attempted to cross-post, this error message was entered into the 'error' table in The Schwartz database:

Can't call method "pre_crosspost_hook" on an undefined value at /home/dw/cgi-bin/DW/External/XPostProtocol/LJXMLRPC.pm line 275.

That line reads:

$req = $extacct->externalsite->pre_crosspost_hook( $req );

Thanks for any help on the issues & I am really excited about this codebase!!

Comments

[jimmyb]

afuna Helped me on IRC for #3, finally figured it out. I simply had to restart my Schwartz jobs haha.

I created a DW::External::Site::Scribbld which works if you want to include that in the DW code.

Thanks!!

[allen]

Just for reference, the pre_crosspost_hook error is a bug. You should be able to define an ExternalAccount without having to go into the code and define an External::Site, too. That's what the 'Other Site' option is there for.

Either we need to do a null check there (easy solution) or we need to create a new generic External::Site object for the custom site (a bit more elegant, but would call for more code rewriting).

[jimmyb]

Ah okay, cool, thanks :)