allen: (weeping angel)
allen ([personal profile] allen) wrote in [site community profile] dw_dev 2010-07-30 08:10 pm (UTC)

I marked "It's too hard to find things that need review" not because I can't find things that need review, but because it's too much of a pain to do for something that I don't really like doing in the first place. I mean, I'll go out of my way to find interesting bugs to fix, but if after spending five minutes looking at the review queue I don't find anything to review, I'll use that as an excuse to move on to other things.

The biggest problem from my perspective is that I can't tell which bugs need a first review and which ones are on their fifth round of feedback. I'm much more likely to take a new patch where nobody else has read and understood the bug, set up test cases, etc., and where I'm not going to be stepping on another reviewer's toes. If I could just do a search for bugs that need review and whose QA Contacts are Unassigned (or some something similar, showing that nobody else has reviewed them yet), then I'd be much more likely to look at that list and take something from there.

It might also be nice to separate out QA (does this actually fix the bug? did it break anything else?) from code review (does the code work efficiently? does it follow our coding standards?). It's possible that we could find more people who are comfortable doing one but not the other.

Post a comment in response:

If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org