Question about quick reply

[swaldman]

Hi all,

Testing on my 'hack with a journal in the Abstractia base style, I notice what seems to be an inconsistency:

* If I hit "reply" on an entry, the quickreply box appears, and when I hit "post comment" the comment is posted through AJAXy magic, handled by LJ::Protocol::addcomment.

BUT

* If I hit "reply" on a comment, the quickreply box still appears, but when I hit "post comment" the comment is posted via a page load and talkpost_do.bml.

Is this what's meant to happen? Why the distinction? *how* the distinction? I am confused ;-)

Comments

[azurelunatic]

I have a wild-ass guess, but I'm also delighted to hear from someone who actually knows.

My wild-ass guess is that the cleanup moving things in the direction of LJ::Protocol::addcomment was incomplete, possibly because "oh it's all quickreply unless you load the reply page separately, right?"

talkpost_do.bml is the ancient method, since the days of Brad in his dorm room, adding comments so he could tell someone that they were Wrong on the Internet.

[denise]

I'm pretty sure that's the case, yeah. There might have been a reason for keeping talkpost_do around ... maybe it was for people with JS off as a fallback?

[swaldman]

Talkpost_do is still used for the main non-quick version (SlowReply?). My confusion is over why it seems to be used even by quickreply when responding to a comment, but not when responding to a post, despite the quickreply interface looking the same...