The Great Big Styles Move

[ninetydegrees]

Dear fellow devs,

bug 4726 will move all folders in /bin/upgrading/s2layers/ as well as /bin/upgrading/s2layers.dat to /bin/styles. I have this mostly patched so, if you're currently working on any of these files, please set your bug as blocking mine so I can keep my patch up-to-date and know when it's safe to push it.

Thank you!

P.S. baggyeyes, I've already done this for your bug as I know you're working on it. :)

Comments

[foxfirefey]

Exciting!

[ninetydegrees]

Yes! <3

[baggyeyes]

Thank you! I get (tiny bit) overwhelmed by the Bugzilla boxes.

[ninetydegrees]

::hugs::

[swaldman]

I still find it odd that the styles thingies, which are clearly text files, are under /bin/. But hey :-)

[ninetydegrees]

I don't think layout files are text files but then I may be wrong. :)

[foxfirefey]

Note: Bug 5040 that I made a pull request for makes a change to core2.s2, which I think affects this! (I had to fix a bug in my module implementation. Oops.)

[ninetydegrees]

Added. Thanks! I haven't moved core2.s2 yet (I guessed there would be some changes :) so it's all good. The joy of rebasing. ;)

Edit: I dream of the day style devs have tools they can easily use to switch between views (owner, member, logged out,...).

[foxfirefey]

Oh, interesting proposition! What would really be cool is a style dev playground that had a sample journal with pre-loaded content to test against, with that switching ability!

[fu]

So. Just for your dev server, you can append ?as=username to the URL. So, for example:

?as=system (as user system) ?as=asdoth (unknown user -- will become anonymous) ?as=comm_member (username of someone who is a community member)

Won't help if your'e testing only on live, but should be helpful in your case!

[ninetydegrees]

Yes, please! Generating 50+ comments wasn't particularly fun. Not to mention all the other parameters.

Edit: suddenly had the vision of a dev bar ala nav strip. *chinhands*

[ninetydegrees]

Good to know, thanks!