pauamma: Cartooney crab wearing hot pink and acid green facemask holding drink with straw (Default)
Res facta quae tamen fingi potuit ([personal profile] pauamma) wrote in [site community profile] dw_dev 2012-05-04 10:05 pm (UTC)

Speaking as one of the few people who will review large patches (like the new update page), I think slicing and dicing them would be a mixed blessing. Yes, it's easier to check each of a large number of small patches separately for style compliance, code clarity. proper use of libraries, error checking, etc., and it may be easier for the patch author to deal with piecemeal reviews as well. But that's only part of the problem, because I'd still want to review all patches as a whole, since the overall design may only be visible there, which means all those reviews would only be preliminary.

An alternative would be for the patch author to document the design before handing the first patch of the set for review, so it can be reviewed against the design (and the design itself for sanity) as well as for style etc as described above. This, however, is a change of habits and workflow that may cause as many problems as it may solve, or perhaps more.

Post a comment in response:

If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting

If you are unable to use this captcha for any reason, please contact us by email at support@dreamwidth.org