Site Messages: do we use these at all?

[foxfirefey]

I'm doing a little before-bed Template Toolkitting as a before-bed easy coding thing--I was thinking of converting the site messages area of the admin to TT, but I'm also wondering if we use it at all, or have plans of doing so, in case what I should be doing is figuring out how to jettison it?

Comments

[mark]

Heh, I'm not sure. Give me a code reference?

[foxfirefey]

cgi-bin/LJ/Widget/SiteMessages.pm
htdocs/admin/sitemessages/*

[denise]

I don't even know where those display! If it's what I think it is, it might've been introduced just as we were forking and possibly not 100% implemented?

Either way, we aren't using it and I don't have plans to use it in the future, so as far as I'm concerned it can get yanked.

[foxfirefey]

When I put one in, it displays in a widgety-thing on the homepage, but I'm not seeing other places yet. Good to know it can be yanked! About 100 lines of BML code would go away, ha, another 8.1k to go. (Converting the admin area is my snowball theory of BML riddation. It's about 1/5 of all the BML--significant but not overwhelming to consider!)

[denise]

I *think* it might be the thing that shows the banners on various site-schemed and journal pages. I'm not 100% sure, though.

[janinedog]

Yes. I definitely implemented it while working at LJ...though I don't remember exactly how/where they showed up.

[fu]

It only shows up on the front page, and only if there are site messages. I remember asking about them when I implemented the front page modules long ago, and was told to keep them around "just in case". Over two years later, and that just in case hasn't materialized, so!

[denise]

Yeah, I think I'm pretty okay with dumping it if we haven't used it in like three years. If we do wind up needing it, we'd have to do a ton of work on it anyway, so why not yank it and rebuild it bigger!better!stronger!faster if we need it in the future.

[denise]

*nod* After this long I definitely think that it probably would have bitrotted anyway, so!

[foxfirefey]

Hmm, looks like this might fall under that too:

248 cgi-bin/LJ/NavTag.pm
252 htdocs/admin/navtag.bml
500 total

It looks like the admin interface for tagging resources and stuff? I seem to remember us not using that, either. (Amusingly, when I load it on my dreamhack because I haven't define any there, it tells me "JFTI".)

[foxfirefey]

I think I found another patch of code we don't use!

http://dw-dev.dreamwidth.org/111698.html?thread=904530#cmt904530

[mark]

Agree. Let the fiery purge commence!

[denise]

yup, that's older and was Brad's attempt to make the UI better without doing any real UI work. *g* Rip it, rip it.

[pauamma]

IIRC, if we get rid of those, we can also remove the siteadmin:navtag (spelling not guaranteed) priv.