erika: (quotes: h2g2: reason is out to lunch)
self-admittedly strange on a subatomic level ([personal profile] erika) wrote in [site community profile] dw_dev2011-07-11 22:22
Entry tags:

Code Tour, for dates 2011-6-10 to 2011-7-12, GMT.

Hail and hello, Dreamwidth! I'm [personal profile] erika, and, for better or worse, I'm the one steering this here code tour.

Most of these bug fixes are live, but a few aren't. You're getting a mish-mash of live bug fixes, a few undead (i.e. not live) bug fixes, new themes, and antiquated language because I think it's funny. (Just thank your lucky stars I wasn't sleep deprived when I started this or there'd be more bad jokes.)

Bug 3725: ajax-loader.gif shows white pixel artifacts on dark backgrounds
Category: Misc UI/Frontend
Patch by: [staff profile] fu
Description: The ajax loader gif had some unsightly white pixels. [staff profile] fu shaved them off so now the ajax loader gif has a new haircut and a better look on dark backgrounds.

Bug 3724: Plugin to generate form elements and automatically fill in values for .tt pages
Category: Routing/TT
Patch by: [staff profile] fu
Description: Here comes [staff profile] fu, making babydevs' lives easier with less typing involved for creation of a form element. (What's a form element? Gentle reader, that is a checkbox, dropdown, or place where you enter text.)

Bug 3400: Add option to not display userpic on entries
Category: Style System
Suggested by: [personal profile] ketsu
Patch by: [personal profile] ninetydegrees
Description: On the Customize Journal page, previously you had the option to display your userpic either on the right or the left side. But now, you can choose not to display it at all! A plethora of options, we have for you here at Dreamwidth.

Bug 3720: Fix sidebar width in some styles
Category: Style System
Patch by: [personal profile] ninetydegrees
Description: Some sidebar widths were inappropriately sized, some sidebars were slightly off in placement, and [personal profile] ninetydegrees' awesome attention to even the most minute detail could not let that stand.

Bug 3694: Misc. Themes: 10 themes
Category: Style System
Patch by: [personal profile] ninetydegrees
Description: Themes were made! (by [personal profile] nornoriel and [personal profile] rising) [personal profile] ninetydegrees committed them! And lo, there was much rejoicing.

Bug 3731: Compartmentalize: numbered list lacks proper indentation on sublevels
Category: Style System
Patch by: [personal profile] ninetydegrees
Description: On the style Compartmentalize, the list made by ordered list tags (the <ol> tag) was improperly indented. [personal profile] ninetydegrees to the rescue!

Bug 3677: Cache paid status
Category: Misc Backend
Patch by: [personal profile] exor674
Description: When loading pages, requests for the account status of the user were happening multiple times. [personal profile] exor674 came flying in, with her supercape on, and fixed that so it only happens once and then Dreamwidth remembers.

Bug 3689: Nouveau Oleanders: 6 themes
Category: Style System
Patch by: [personal profile] ninetydegrees
Description: Themes, this time for the style Nouveau Oleanders, done by [personal profile] dancing_serpent!

Bug 3690: Fluid Measure: 5 themes
Category: Style System
Patch by: [personal profile] ninetydegrees
Description: More themes, also by [personal profile] dancing_serpent, but for the style Fluid Measure.

Bug 3692: Refried Tablet: 5 themes
Category: Style System
Patch by: [personal profile] ninetydegrees
Description: More gorgeous themes by [personal profile] dancing_serpent, for Refried Tablet.

Bug 3735: index for /security has mislabeled link
Category: Circle/Relationships
Patch by: [staff profile] fu
Description: Denise caught that the page for filtering entries by account security said Access List twice, and one of them actually led to Private entries. Fixed by the stellar [staff profile] fu. In addition, fu sneakily fixed the English stripping of the page—which just sounds like a punishment for naughty schoolboys, no matter how I try to think about it.

(Also, I didn't even know that page existed, and yet it is AWESOME. How are you so awesome, Dreamwidth?)

Bug 3736: circle gifts page: don't show "buy points" message for comms
Category: Payments
Patch by: [staff profile] fu
Description: As Denise wrote in the bug page,
"the "Buy points" link shouldn't appear for comms, since you can't buy points for a comm and just leads to an error message anyway."


Well put, and so I stole it, because less work for me = happy (lazy) [personal profile] erika.

Bug 3737: circle gifts page: don't show "buy gift" for seed accounts
Category: Payments
Patch by: [staff profile] fu
Description: It doesn't make sense to allow us, the hardworking (and hardly working) denizens of Dreamwidth, to buy paid time for seed accounts because... uh... they're seed accounts. But you should be able to buy points for them, because everybody loves points! This fixes that so it's like what I said.

Bug 3638: Trying to screen/freeze comments via the inbox throws up an "Invalid form submission" error
Category: Journal contents
Patch by: [staff profile] fu
Description: Formerly, if you tried to screen or freeze comments via the inbox, it gave you an error, and now it shouldn't!

Bug 3739: Credit Card Page using http (not https) just shows a link
Category: Payments
Patch by: [staff profile] fu
Description: If you tried to go to the page to enter your credit card number using regular http protocol and not the secure https protocol, you ended up with a page with nothing but a URL on it. Not. . . really. . . all that helpful. So [staff profile] fu and her magic fingers made it a redirect instead!

Bug 3738: Usernames from non-LJ based sites are treated like they're from LJ-based sites
Category: Journal contents
Patch by: [staff profile] fu
Description: Certain things only need to happen to LiveJournal usernames, such as converting underscores to hyphens and some other limits. Dreamwidth was mistakeningly treating all usernames as if they were from a LJ-based site, so once again, [staff profile] fu to the rescue!

Bug 3741: JS broken in talkread
Category: Journal contents
Patch by: [staff profile] fu
Description: In production, all JS files on a page get glued together into one long JS file. BUT. If it happens to be the case one is missing, it fails entirely. This makes [staff profile] fu very sad. She fixed it!

Bug 3742: Parts of the contextual hover menu may spill over the edge of the screen
Category: Misc UI/Frontend
Patch by: [staff profile] fu
Description: UI dance of frustration! The changing position of the hover menu on the main site is only done once. What if the window is resized?! Beset with worry, [staff profile] fu's brow furrowed, and code appeared! Now, the hover menu shall dance appropriately!

Bug 3743: "DOM not defined" error when in jquery beta
Category: Misc UI/Frontend
Patch by: [staff profile] fu
Description: People in the beta were getting some weird errors. This patch caught one of the weird errors, tied it down so it couldn't get away, and systematically eradicated it.

Bug 3744: "Can't call inprogress on ftp://ftp." error when you click elsewhere while any ajaxtip is still loading
Category: Misc UI/Frontend
Patch by: [staff profile] fu
Description: If you clicked elsewhere while an ajaxtip (i.e. a contextual hover) was loading, you got a nasty error. [staff profile] fu, as is her wont, eliminated it with extreme prejudice.

Bug 3745: delcommentcomplete event not called when the AJAX request errors
Category: Journal contents
Patch by: [staff profile] fu
Description: The first time I saw this, I thought [staff profile] fu's description of the bug sounded like something out of Alice in Wonderland. Being as I'm not sure I can phrase it any better, here's her description:
We send out a custom [widgetname]complete event when we're done with an AJAX request, so that anything interested in that request (say deleting a comment or screening one) can do something when it's been completed.

However, due to the way it was structured, we were sending a [widgetname]complete event when it succeeded, and an ajaxtipcomplete event when there was an error, which meant that we couldn't find out when [widgetname] was done doing what it was doing.


Bug 3732: Practicality: 10 themes by [personal profile] rising
Category: Style System
Patch by: [personal profile] ninetydegrees
Description: Themes, gloriiiiious themeeeeees... I'm sorry, where was I? What was I doing? Oh yes. These are some themes for Practicality, by [personal profile] rising!

Bug 3750: Contextual hover for communities broken
Category: Misc UI/Frontend
Patch by: [staff profile] fu
Description: Beta users were seeing a contextual hover (which is when you put your cursor over a link and a menu pops up) with some broken elements instead of the right ones. [personal profile] yvi reported it and [staff profile] fu to the rescue!

(Hey, that rhymes! It's also the second time I've said it in this bug tour. Oops. Oh well—come for the bugs, stay for the originality and sparkling wit, amirite?)

Bug 3752: Errors in Brittle/Pressed Flowers and Modular/Heart of Darkness
Category: Style System
Patch by: [personal profile] ninetydegrees
Description: There was inexplicable weird stuff with color codes, much like an unmade bed. This patch remakes the bed.

Bug 3763: /manage/moodthemes links to wrong page
Category: Misc UI/Frontend
Patch by: [personal profile] ninetydegrees
Description: If you hadn't made any custom mood themes, the custom mood theme editor linked to the wrong page to select a public mood theme. Where, oh where, am I supposed to select a public mood theme? Fear not, for [personal profile] ninetydegrees has ferreted out the deceit and remade the custom mood theme editor just like brand new, except now it has a link to the proper page. And there was great rejoicing in the land.

Bug 3766: Account Settings: display the NCTalkLinks option to OpenID users
Category: OpenID
Patch by: [personal profile] ninetydegrees
Description: This allows OpenID users to use an option that changes the link to a page based on the number of comments the page has.

Bug 3761: Account Settings: Random Paid Gifts shouldn't be displayed to OpenID users
Category: Misc UI/Frontend
Patch by: [personal profile] ninetydegrees
Description: As [personal profile] ninetydegrees aptly summarized, "OpenID users can't upgrade to a paid account so they can't be sponsored. This setting shouldn't be displayed to them."

Bug 3722: Misc. Themes: 19 themes
Category: Style System
Patch by: [personal profile] ninetydegrees
Description: [personal profile] ninetydegrees committed NINETEEN THEMES in the same bug. Wow. These themes were by [personal profile] nornoriel and [personal profile] rising, for the styles: Blanket, Brittle, Compartmentalize, Funky Circles, Modular, and Practicality!




And now we come, sadly, to the end of the code tour. Fellow sailors on the great ship Dreamwidth: I bid you a fond farewell!
denise: Image: Me, facing away from camera, on top of the Castel Sant'Angelo in Rome (Default)

[staff profile] denise 2011-07-12 03:55 (UTC)(link)
Awesome code tour is awesome. Thank you!
msilverstar: (corset)

[personal profile] msilverstar 2011-07-12 05:57 (UTC)(link)
nice job!
fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)

[staff profile] fu 2011-07-12 08:06 (UTC)(link)
Ahaha love it :-)
musyc: Text reading "keep calm and do what the coffee says" (Coffee: Keep calm)

[personal profile] musyc 2011-07-12 13:01 (UTC)(link)
*applauds* Excellent code tour! I ♥ DW for actually telling us all of this. Even if it's codelike backend stuff that operates by MAGIC as far as I'm concerned, it's neat to see what gets done. XD
pauamma: Cartooney crab holding drink (Default)

[personal profile] pauamma 2011-07-13 19:21 (UTC)(link)
What did you spray on your shirt this time? :-)
musyc: Text: I'm not insane, my mother had me tested (Quote from Big Bang Theory) (Text: I'm not insane)

[personal profile] musyc 2011-07-13 20:18 (UTC)(link)
I HAVE NO IDEA WHAT YOU'RE TALKING ABOUT I PLEAD THE FIFTH possibly I might have dropped some toast crumbs but that's it I AM INNOCENT YOUR HONOR
pauamma: Cartooney crab holding drink (Default)

[personal profile] pauamma 2011-07-13 20:39 (UTC)(link)
/me looks insufferably smug.
aedifica: Me looking down at laptop (off screen).  Short hair. (Default)

[personal profile] aedifica 2011-07-12 17:47 (UTC)(link)
Do the themes glorious themes come with cold jelly and custard? Enquiring minds who grew up singing along with the Oliver soundtrack want to know!
glitch25: (Default)

[personal profile] glitch25 2011-07-12 18:23 (UTC)(link)
Yay for the Zork reference!

[personal profile] lilmoka 2011-07-12 20:24 (UTC)(link)
Wonderful code tour, honey! :)
azurelunatic: Azz and best friend grabbing each other's noses.  (Default)

[personal profile] azurelunatic 2011-07-14 00:17 (UTC)(link)
Yay tour!
pensnest: bright-eyed baby me (Default)

[personal profile] pensnest 2011-07-25 08:35 (UTC)(link)
What a charming code tour. :-D
keris: Keris with guitar (Default)

[personal profile] keris 2011-07-29 08:15 (UTC)(link)
I love the style, I wish our change summaries at work were like this. Being of a whimsical bent myself (/* IM IN UR CODE FIXIN UR BUGZ */) I think it's lovely.
denise: Image: Me, facing away from camera, on top of the Castel Sant'Angelo in Rome (Default)

[staff profile] denise 2011-07-29 08:18 (UTC)(link)
If you browse back over past code tours, you will find that many of them are delightfully ... shall we say, less than serious. *g* (I love seeing everybody's code tour style; it's one of the main reasons why I encourage lots of different people to host the code tours in turn!)