foxfirefey: Fox stealing an egg. (Default)
foxfirefey ([personal profile] foxfirefey) wrote in [site community profile] dw_dev2009-09-28 08:10 pm
Entry tags:

Code tour: 9/21 to 9/27

Here is this week's code tour! We closed a total of 21 bugs. Thank you to our submitters this week (in no particular order): [personal profile] yvi, [personal profile] wyntarvox, [personal profile] snakeling, [personal profile] cesy, [staff profile] denise, [personal profile] afuna, [personal profile] twtd, [personal profile] zvi, [personal profile] szabgab, [personal profile] kareila, [personal profile] exor674, and [personal profile] ninetydegrees (who submitted her first direct patch this week)! If you are thinking about volunteering for doing a code tour at some point, I've started a guide on the process. These patches aren't live yet; you can keep track of which patches are live on the code status page.


Bug 1281: Sticky entry module
Category: Style System
Patch by: [personal profile] yvi
Description: This is pretty exciting! [personal profile] yvi has been very hard at work lately developing a sticky module for the style system, so that you can set one entry that sticks up at the top of your recent entries page. What's more, it should work in all core styles, and it stays with the journal and not the style (that is, viewing someone else's journal in your style shows you their sticky entry, not yours). It works for communities, too!

Bug 1403: add ?mode=full link to the profile
Category: Misc UI/Frontend
Patch by: [personal profile] yvi
Description: So, once upon a time I wrote a patch to not show deleted (and thus struckthrough) accounts from your list of subscribers or people who gave you access. (They'd still show on the profile if it was a relationship you had control over, though, such as someone you subscribed or gave access to.) There was a ?mode=full option you could add on the end of the URL to show those accounts again, though. This page adds a link to that option.

Bug 1510: S2 should have placeholder for comment titles
Category: Style System
Patch by: [personal profile] wyntarvox
Description: This actually ended up adding a permalink to comments and only showing the thread link if there were replies.

Bug 1612: Links are underlined in Tropospherical, breaking browser preferences
Category: Misc UI/Frontend
Patch by: [personal profile] snakeling
Description: We were specifically setting links to be underlined, but we didn't need to, and some people set their browsers to not underline links. This bug addressed this suggestion.

Bug 1620: include entry title in comment notification email
Category: Inbox/Notifications
Patch by: [personal profile] wyntarvox
Description: This adds the title of your entry to your notification of someone commenting on it.

Bug 1698: link to project team communities on staff page
Category: Frontend
Patch by: [personal profile] cesy
Description: In an effort to be better organized and more transparent about how we operate, we've added links to the different team communities on the staff page.

Bug 1725: Navigation bar hrefs break on apostrophes
Category: Misc UI/Frontend
Patch by: [staff profile] denise
Description: Tags containing apostrophes would break the links on the nav bar! This makes sure those links are escaped.

Bug 1727: Contextual popup links don't set a default color
Category: Misc UI/Frontend
Patch by: [staff profile] denise
Description: This sets a default link color for the contextual popup--styles can override this, but this at least ensures that we don't get link colors that can't be read on the default background.

Bug 1765: Code cleanup in manage/settings/index.bml.text
Category: Misc Backend
Patch by: [personal profile] kareila
Description: This is removing an unused string that contained LiveJournal.

Bug 1786: need friendly error message when uploading unallowable icon files
Category: Misc UI/Frontend
Patch by: [personal profile] kareila
Description: Unknown formats for icon uploads used to make an ugly error and just die. Now, there is a much friendlier error that doesn't mention lines of code.

Bug 1795: Network page uses text_post_comment instead of text_post_comment_friends
Category: Style System
Patch by: [personal profile] kareila
Description: The Network page was using the wrong text description for post comment links because of our backend changing of the page from "read" to "network". This makes sure that the Network page uses the same post comment link text as the Read page.

Bug 1799: Poster not displayed for entries with no userpics in Funky Circles
Category: Style System
Patch by: [personal profile] ninetydegrees and [personal profile] afuna
Description: This fixes a bug with Funky Circles where the poster didn't display if an entry didn't have a userpic.

Bug 1812: change text for "Custom Friends Groups" in S2
Category: Style System
Patch by: [personal profile] kareila
Description: Oh dear. We don't *have* custom friends groups, so [personal profile] kareila fixed the terminology for us.

Bug 1814: Modish & Boxes and Borders footers have hardcoded white color; Boxes and Borders does not use footer colors to control presentation
Category: Style System
Patch by: [personal profile] kareila
Description: This fixes some color problems with the Modish and Boxes and Borders layouts and hooks them up with the right S2 properties.

Bug 1817: Theme: Repose (Basic Boxes)
Category: Style System
Patch by: [personal profile] wyntarvox, [personal profile] twtd, [personal profile] piranha
Description: [personal profile] twtd made this theme for Basic Boxes, [personal profile] wyntarvox converted it, and [personal profile] piranha made the preview thumbnail.

Bug 1822: typo in tropo footers
Category: Misc UI/Frontend
Patch by: [personal profile] kareila
Description: Somehow an extra "?" got into the link for Open Source in the Tropospherical footers. Whoops! This gets rid of it.

Bug 1824: Theme: Sprung (Blanket)
Category: Style System
Patch by: [personal profile] wyntarvox, [personal profile] zvi, [personal profile] piranha
Description: This is a theme for the Blanket layout done by [personal profile] zvi! [personal profile] wyntarvox made the patch for it, and [personal profile] piranha made the thumbnail preview.

Bug 1833: unit tests fail due to prototype mismatch
Category: Misc Backend/Testing
Patch by: [personal profile] szabgab
Description: [personal profile] szabgab, as you may or may not know, has been doing wonderful work lately modernizing the code base and fixing our unit tests.

Bug 1844: Cannot clear sticky entry setting.
Category: Misc UI/Frontend
Patch by: [personal profile] exor674
Description: Looks like there was a bug where the sticky entry couldn't be cleared. This also makes it so that it also validates you are giving it a valid entry number.

Bug 1882: Missing space on see_request.bml
Category: Misc UI/Frontend
Patch by: [personal profile] wyntarvox
Description: This is a nitpicky little fix that adds a space between 'email validated?yes' on see_request.bml.

Bug 1884: Funky Circles fixes for reply page
Category: Style System
Patch by: [personal profile] ninetydegrees
Description: This is [personal profile] ninetydegrees first patch, as far as I know! She did some CSS fixes for Funky Circle reply pages.
wyntarvox: (Default)

[personal profile] wyntarvox 2009-09-29 04:05 am (UTC)(link)
This is a nitpicky little fix that adds a space between 'email validated?yes' on see_request.bml.

This describes the thing I like best about doing development on DW: I can easily report and fix things that annoy me in my own general use of the site!
yvi: Kaylee half-smiling, looking very pretty (Default)

[personal profile] yvi 2009-09-29 05:41 am (UTC)(link)
Bug 1281: Sticky entry module

And it works for communities!

\o/ :)

Bug 1727: Contextual popup links don't set a default color

Finally no more white links on a white background :)
yvi: Kaylee half-smiling, looking very pretty (Default)

[personal profile] yvi 2009-09-29 07:59 am (UTC)(link)
Thank you! The thing is mostly that while the bug is called "Sticky entry module", it didn't actually get to be an S2 module, but a setting, so that's why the style has no effect on it.

Oh, and I completely forgot that I wanted to think [personal profile] afuna and [personal profile] exor674 for all the help on that one. I assigned myself to it when I was still a small, confused dev and was in way over my head :) But I wanted to have it implemented so much that I decided to code it myself. Dreamwidth development is evil that way :)
afuna: Cat under a blanket. Text: "Cats are just little people with Fur and Fangs" (Default)

[personal profile] afuna 2009-09-29 04:51 pm (UTC)(link)
PSst, you rock \ol
baggyeyes: Princess Leia (Default)

[personal profile] baggyeyes 2009-09-29 05:11 pm (UTC)(link)
++1
trinity_clare: elphaba cannot possibly roll her eyes harder (giggle oy)

[personal profile] trinity_clare 2009-09-29 05:59 am (UTC)(link)
This is removing an unused string that contained LiveJournal.

All of LiveJournal? It must have been a hell of a string. :D
jss: (badger)

[personal profile] jss 2009-09-29 10:41 pm (UTC)(link)
It was probably just the md5sum hash.
ninetydegrees: Drawing: a girl's face, with a yellow and green stripe over one eye (Default)

[personal profile] ninetydegrees 2009-09-29 02:03 pm (UTC)(link)
The hardest part was understanding how to clone the dw repository using Tortoise... I'm tempted to make a guide for dummies. ;)
afuna: Cat under a blanket. Text: "Cats are just little people with Fur and Fangs" (Default)

[personal profile] afuna 2009-09-29 04:51 pm (UTC)(link)
Oh hey, how are you with wikis? It would be awesome if you could talk to [personal profile] av8rmike, who did the beginnings of some of the instructions here:

http://wiki.dwscoalition.org/notes/Working_on_a_Styles_Bug
ninetydegrees: Drawing: a girl's face, with a yellow and green stripe over one eye (Default)

[personal profile] ninetydegrees 2009-09-29 05:02 pm (UTC)(link)
Yeah I read that and it wasn't helpful to me because it's not made for Windows people who don't know what the heck this guide talks about. If I write a guide, I don't know if I'll wikified it. I don't really like wiki-editing but I'll see then. Right now I'm trying to understand how to work with PuTTY and an external editor/patch generator. None of the integrated editors are user-friendly and I don't want to work with them.