foxfirefey: Fox stealing an egg. (Default)
foxfirefey ([personal profile] foxfirefey) wrote in [site community profile] dw_dev2009-09-14 09:27 pm
Entry tags:

Code tour: 9/9 to 9/14

Code tour time! We set the status on 30 bugs this week to FIXED, and as far as I know all these patches are currently live.

Bug 132: Inbox sub-filter refreshes to wrong page when deleting all
Category: User Interface -- Inbox
Patch by: [personal profile] afuna
Description: Fixes a usability bug so that if you've selected a subfilter and perform some action on all of it, it now refreshes back to the subfilter page unless there are no more items in the subfilter instead of going back to the entire inbox.

Bug 701: ext_nnn form used for OpenID users in various PM-related locations
Category: User Interface -- OpenID
Patch by: [personal profile] yvi
Description: We're trying to get rid of the outward facing uses of the clumsy fake usernames OpenIDs get.

Bug 797: un-hide quote button for newer versions of Opera
Category: User Interface
Patch by: [personal profile] afuna
Description: Since the latest versions of Opera work with the quote button in the comment form, we're stopping special casing and hiding it from Opera.

Bug 857: Support fdata.bml
Category: APIs (RPC, XML, Flat)
Patch by: [staff profile] mark (but attributed to [personal profile] foxfirefey)
Description: Attributing this patch to me would be a LIE, really, because [staff profile] mark did most of it and rearranged it to be more size efficient! This patch implements something we've been missing, which is a machine-friendly way to access a user's relationships with other users. LJ tools like Joule would use this. Now DW can use this data, too! You can see [community profile] memewidth for playing around with this kind of data.

Bug 1039: if PayPal times out at the "confirm payment" step, user gets zombie cart
Category: Site Administration
Patch by: Nobody!
Description: This is a zombie bug--other patches have made this problem not happen anymore.

Bug 1089: Guides need to be searchable
Category: User Interface
Patch by: [personal profile] afuna
Description: This makes it so that all FAQs get searched, even those with no category.

Bug 1158: OpenID accounts missing comment management options on customized comment pages
Category: Style System
Patch by: [personal profile] yvi
Description: On styled entries pages (such asTransmogrified, Negatives, and blank core2) OpenID users didn't have any comment management options - no
delete, just 'track this' and 'reply' - so this fixes that.

Bug 1551: Kill the portal
Category: Misc Backend
Patch by: [personal profile] exor674
Description: This just removed some tables leftover from ripping out the portal code.

Bug 1605: Support colours broken in IE7
Category: Unknown
Patch by: [personal profile] afuna
Description: Puts back the green/yellow colors in the table for IE7.

Bug 1611: Brainstorm thread for how to handle different problems with printing stylesheets
Category: Style System
Patch by: [personal profile] afuna
Description: We're trying to make it easier for styles based *on* Tabula Rasa and other base styles to print out different stylesheets.

Bug 1656: Move the setting of color properties from layout layers to the default theme layer
Category: Style System
Patch by: [personal profile] afuna
Description: This will allow people overriding the layout layer entirely to do so, without having to be affected each time we add a new color to their layout.

Bug 1658: "Mass action on selected comments" has no <label>
Category: Style System
Patch by: [personal profile] afuna
Description: This helps for usability--form items should have <label>s.

Bug 1695: add suggestions generator to site map and site footer
Category: Frontend
Patch by: [personal profile] yvi
Description: Adds a link to the footer to the suggestions generator, to make it easier for people to submit suggestions.

Bug 1699: Change subject line for poll response emails
Category: Inbox/Notifications
Patch by: [personal profile] yvi
Description: Changes the subject lines for email notifications of polls to "Someone replied to poll #111 'Topic'" so they thread more sensibly.

Bug 1704: Recent Comments page uses old URL structure for anchors
Category: Misc UI/Frontend
Patch by: [personal profile] yvi
Description: This fixes links on the recent comments page to use the current comment anchor structure.

Bug 1714: Missing left border on support/help
Category: Misc UI/Frontend
Patch by: [personal profile] afuna
Description: Fixes the missing border along the left hand side of the list of help requests in Firefox 3.5.

Bug 1729: Basic Boxes module header not set in some themes
Category: Style System
Patch by: [personal profile] afuna
Description: Fixes the Basic Boxes module header color to be the same as the entry title color unless specifically set.

Bug 1738: Basic Boxes/ColorSlide: inconsistent alignment of Module headers
Category: Style System
Patch by: [personal profile] yvi
Description: More CSS fixes for the module headers Basic Boxes.

Bug 1749: Add the option to send a message while adding someone to your circle
Category: Misc UI/Frontend
Patch by: [personal profile] yvi
Description: If user allows PMs, this makes it easier to send a PM to someone while you're subscribing or giving access to them.

Bug 1752: S2: New tag classes on the Tags page
Category: Style System
Patch by: [personal profile] cesy
Description: Add a class specifying the display style of tags - List, Multilevel list and Cloud - on the Tags page.

Bug 1754: Extra "Save" button on Manage Subscriptions page
Category: Inbox/Notifications
Patch by: [personal profile] cesy
Description: Adds an extra save button to the top of notifications tab, so you don't have to scroll to the bottom.

Bug 1762: Plain text layersource view does not work in IE
Category: Style System
Patch by: [personal profile] afuna
Description: Fixes a bug preventing viewing of plain text layer sources.

Bug 1767: Base layouts category for styles
Category: Style System
Patch by: [personal profile] afuna
Description: This adds a base layouts category for styles, in accordance to this poll.

Bug 1769: Layout: Funky Circles
Category: Style System
Patch by: [personal profile] ninetydegrees and [personal profile] afuna and [personal profile] piranha
Description: This is a new layout by [personal profile] ninetydegrees! [personal profile] afuna put it in patch form and [personal profile] piranha made the screenshot.

Bug 1775: Content warning cut text inconsistent
Category: Journal contents
Patch by: [personal profile] chemicallace
Description: Changes an instance of "community maintainer" to "community administrator" to be consistent.

Bug 1778: $.view for Network is equal to $.view for the plain Read page
Category: Style System
Patch by: [personal profile] afuna
Description: Changes the variable in the S2 system backend to properly say what view is being used. Causes some issues, but helps us move forward.

Bug 1779: Don't ping hubbub if updating a syndicated journal
Category: APIs (RPC, XML, Flat)
Patch by: LiveJournal
Description: We don't make feeds for syndicated journals, so we shouldn't ping hubbub when they are updated.

Bug 1783: Network view in S2 should pay attention to cap, not paid status
Category: Style System
Patch by: [personal profile] foxfirefey and [personal profile] afuna
Description: I made a mistake with an earlier patch and was making the network view in the list of S2 pages depend on paid status, when it should really pay attention to whether or not the user has the capability.

Bug 1789: Sunday Morning improperly credited
Category: Style System
Patch by: [personal profile] afuna
Description: Makes the Sunday Morning layout have the appropriate credit reference.

Bug 1791: sort users alphabetically on Manage Subscription Filters page
Category: Misc UI/Frontend
Patch by: [staff profile] mark
Description: This was a quick little bug to make user be sorted alphabetically on the beta Manage Subscription Filters page.

For code tour makers, I've made a cheap little Python script to help me make this code tour from a saved CSV of a bug search.



#!/usr/bin/env python

# usage: python code_tour_template.py bugs-2009-09-15.csv

import csv, re, sys

def parse_assignment(assign):
    match = re.search('\[\:([a-z0-9_]+)\]', assign);

    try:
        return "".join(['<user name="', match.group(1), '">'])
    except (IndexError, AttributeError):
        return assign

bugs_file = sys.argv[1]

bugReader = csv.DictReader(open(bugs_file))

template_record = """<b><a href="http://bugs.dwscoalition.org/show_bug.cgi?id=%(bug_id)s">Bug %(bug_id)s</a>:</b> %(title)s
<b>Category:</b> %(category)s
<b>Patch by:</b> %(patch_by)s
<b>Description:</b> FILL IN
"""

for row in bugReader:
    replacements = { "patch_by": parse_assignment(row["assigned_to_realname"]),
        "bug_id": row["bug_id"],
        "category": row["component"],
        "title": row["short_desc"] }
    
    print template_record % replacements
yvi: Kaylee half-smiling, looking very pretty (Default)

[personal profile] yvi 2009-09-15 05:43 am (UTC)(link)
Oh, shiny Python script! Very nice.

My goal to be included in this week's code tour obviously was reached ;)
cesy: Home is where the <3 is (Dreamwidth) (Dreamwidth)

[personal profile] cesy 2009-09-15 06:11 am (UTC)(link)
Yay, so many exciting bugs!
azurelunatic: A glittery black pin badge with a blue holographic star in the middle. (Default)

[personal profile] azurelunatic 2009-09-15 06:36 am (UTC)(link)
And I have added "edges" to the Jargon page.
mark: A photo of Mark kneeling on top of the Taal Volcano in the Philippines. It was a long hike. (Default)

[staff profile] mark 2009-09-16 03:23 am (UTC)(link)
I just spent a few minutes boggling at how you got a CVS dump of the repositories before I realized that I think you mean CSV dump...
roadrunnertwice: Vesta Tilley, Victorian drag king (Rocket Scientist)

[personal profile] roadrunnertwice 2009-09-18 08:19 am (UTC)(link)
Personally, my brain always strips a gear whenever someone mentions the CVS pharmacy chain.