kareila: Rosie the Riveter "We Can Do It!" with a DW swirl (dw)
kareila ([personal profile] kareila) wrote in [site community profile] dw_dev2014-07-12 06:14 pm
Entry tags:

Code tour for June 11 - July 12 2014

[personal profile] afuna and I have worked together to bring you this hand-crafted code tour of issues that have been closed in the past month or so. These fixes should all be live on the site after tomorrow night's code push if they're not already.

If any of my descriptions are too obtuse, let me know and I will try to clarify them!


Issue #: Former bug 5323: Disable parsing of external entities in synsuck and the importer
Fix by: [staff profile] fu
Description: This code customizes the standard Perl XML parser module to always use a tighter security configuration than the default setup, since we can't trust external data sources not to contain maliciously formatted data.

Issue #: (none): Always use LJ::challenge_check_login
Fix by: [staff profile] fu
Description: We need to make sure we use the same mechanism to authenticate logins, regardless of whether the browser has disabled JavaScript.

Issue 733: Fix syntax error in approve.bml
Fix by: [staff profile] fu
Description: Properly escaping nested-double quote characters can be tricky! This fixes a syntax error that crept into one of the community pages.

Issue 734: Fix nested comments not showing up sometimes
Fix by: [staff profile] fu
Description: The recent fix for pages with deeply-nested comments would, in certain circumstances, cause replies not to be printed at all. This code makes two copies of the data structure so that we don't lose track of those replies.

Issue 735: Hush various warnings
Fix by: [staff profile] fu
Description: Development servers like to fill up their server logs with warnings whenever empty variables are operated on. This quiets some of those warnings.

Issue 740: Fix POSTing of changeemail
Fix by: [staff profile] fu
Description: This brings the form processing code on the /changeemail page into line with the DW::Request post format, and allows the page to work correctly when accessed over SSL.

Issue 736: Better error message when cleaning out purged members
Fix by: [staff profile] fu
Description: When cleaning out purged members from a community, we now show a more accurate, less confusing success message. The message for other uses cases is unchanged.

Issue 737: Don't try to convert "0000-00-00" to a time
Fix by: [staff profile] fu
Description: A date string full of zeroes isn't a useful time indicator, so we should recognize it and bail out of trying to parse it when we see it.

Issue 741: Don't print out too many closing divs
Fix by: [staff profile] fu
Description: If you could drive a car straight down into the ocean, and the wheels kept spinning after you hit the ocean bottom and couldn't go any further, and then you used the odometer to try to figure out how far up to go to get back to the surface, you might end up in midair somewhere. This is like that, except for threaded comment depth.

Issue 745, 746, 750, 758, dw-nonfree#60, dw-nonfree#62: Tweaks to Foundation-styled pages based on user feedback
Fix by: [staff profile] fu
Description: In case you haven't noticed, the community management pages have been redesigned to use responsive CSS! This handful of issues contains the many tweaks we've made to improve the appearance of these pages based on user feedback.

Issue 747: Add metadata to interestdata
Fix by: [personal profile] sophie
Description: This code includes additional user data in the raw interest data available via the API (but see issue #752 below).

Issue 751: Fix issue with community list display
Fix by: [staff profile] fu
Description: There was an issue with one of the new community pages, where the Compass system was printing out unwanted HTML tags in a certain context. This fixes that.

Issue 754: Reject member if ban is successful
Fix by: [staff profile] fu
Description: It looks like a line of code for rejecting a banned user from rejoining a community was commented out when testing the page redesign. Oops!

Issue 753: Add back ability to convert personal journals to communities
Fix by: [staff profile] fu
Description: This was a feature that was accidentally omitted from the redesigned community management pages, so it was quickly added back in under a new URL.

Issue 755: Use SSL when converting communities
Fix by: [staff profile] fu
Description: This tweaks the new /communities/convert page to prefer using an SSL connection.

Issue 743: Allow emailed entries to have too-long subjects
Fix by: [staff profile] fu
Description: At some point we decided to have journal posts fail with an error message if the subject line was longer than the allowable character limit. But some methods of posting aren't interactive, such as posting by email, and we can't send back the error - so for those cases, we now quietly truncate the subject again.

Issue 506: Allow other sites to authenticate to DW using OAuth (former bug 5062)
Fix by: [personal profile] exor674
Description: These are the backend changes necessary to support using OAuth 1.0a authentication in the future.

Issue 761: Fix broken domain name in the style guide
Fix by: [staff profile] fu
Description: The SCSS style guide for developers had some links that accidentally led back to [staff profile] fu's dreamhack box, so we've fixed those to point to Dreamwidth instead.

Issue 693: Create nice month view for siteviews
Fix by: [personal profile] momijizukamori
Description: This create a month (archive) view using S2 for journals viewed in the site style. It was using a BML page before, and we're trying to get rid of those.

Issue 764: /admin/propedit should warn if you have canview:userprops but not siteadmin:
Fix by: [staff profile] denise
Description: It's possible to have a set of admin privileges that would let you view but not edit certain data on the site. [staff profile] denise got frustrated by this one too many times, and wrote a patch to print a warning message when that happens.

Issue 769: Add MIME::Base64::URLSafe to checkconfig.pl
Fix by: [personal profile] sophie
Description: This makes sure that a Perl module used by the new OAuth code is installed.

Issue 767: Add 'suspend notes' for antispam team
Fix by: [staff profile] denise
Description: We've added a new administration feature requested by the antispam team: the ability to leave notes on frequently reported accounts to make it easier to keep track of them.

Issue 774: Make success_ml use the same format as DW::Template->render_template
Fix by: [staff profile] fu
Description: This tweaks the arguments to the success_ml function to make them consistent with another, similar function. Consistency means fewer bugs!

Issue 720: Add flickr embeds to our whitelist
Fix by: [personal profile] stormerider
Description: We now allow journal entries to display embedded content from flickr.com.

Issue 725: Zero count spamreports lose breadcrumbs
Fix by: [personal profile] stormerider
Description: The site navigation "breadcrumbs" weren't being printed on spamreport pages that had no reports to display.

Issue 765: Comments failing to import from LiveJournal
Fix by: [staff profile] fu
Description: The changes to the XML parser that I described way, way back at the top of this list? Broke the comment importer. Oops!

Issue 781: Fix bad merge in t/use-strict.t
Fix by: [staff profile] fu
Description: Looks like one of our test suites was accidentally reverted to an earlier version by a bad merge.

Issue 782: Fix miscellaneous tests
Fix by: [staff profile] fu
Description: Occasionally we remember to run the tests, and discover that they need to be updated to account for recent changes. :)

Issue 779: Add "rcptid" to the list of primary keys when moving users between clusters
Fix by: [staff profile] fu
Description: This is deep voodoo involving moving stuff around on clustered databases. Basically, we added a new database table and the cluster mover script didn't know how to figure out which user the data belonged to.

Issue 783: Inbox message is warning when notifying of moderated community post
Fix by: [staff profile] fu
Description: When a moderated entry was approved or rejected, the moderation notification would choke and print ugly code warnings. Now we display a friendlier "this entry has been handled" message.

Issue 731: Remove past-dating checks on posting, allow any time
Fix by: [staff profile] fu
Description: Going forward, we've decided to allow posting journal entries out of chronological order. See http://dw-dev.dreamwidth.org/154479.html for discussion and rationale.

Issue 748: Five new themes for Ciel by [personal profile] dancing_serpent, with previews
Fix by: [personal profile] momijizukamori
Description: Five new themes for Ciel! Looks like they are called Dried Flowers, Marble IV, Quasar, Rose Garden I, and Rose Garden II.

Issue 752: Add user-side /data/interests (JSON), remove site-side /misc/interestdata
Fix by: [personal profile] sophie
Description: This replaces the old /misc/interestdata.bml with a new /data/interests API, which uses JSON. If these words don't mean anything to you, don't worry! It just lets programmers do stuff with our site's data in programatic ways.

Issue 788: Members not getting posting access in communities when they accept invite
Fix by: [staff profile] fu
Description: We fixed a reported issue with the new community management pages, where newly-invited members would not automatically receive permission to post entries to the community.

Issue 701: Automatically add a label based on a comment in a Github issue
Fix by: [staff profile] fu
Description: We've added a Dreamwidth-specific code hook to facilitate the automatic labeling of issues in our bug tracker on Github. Since Github doesn't allow us to do what we want natively, we're providing our own API for it.

Issue dw-nonfree#64: Assign to someone who "claim"s a bug
Fix by: [staff profile] fu
Description: More Github API work, allowing users to self-assign issues by commenting there.

Issue 722: Have TR-based styles automatically fall back to one-column styling on smaller screens
Fix by: [staff profile] fu
Description: To make journal styles more mobile-friendly, many of them will now use one-column styling when loaded on small screens.

Issue 723: Make navigation strip work for smaller screen sizes
Fix by: [staff profile] fu
Description: Allow the navigation strip at the top of a journal page to break into multiple lines on small screens.

Issue 724: Add a "jump to modules" link to styles
Fix by: [staff profile] fu
Description: When viewing a journal on a small screen, in addition to using a one-column layout, add a "jump to modules" link to skip down to the module content.
denise: Image: Me, facing away from camera, on top of the Castel Sant'Angelo in Rome (Default)

[staff profile] denise 2014-07-13 03:51 am (UTC)(link)
If you could drive a car straight down into the ocean, and the wheels kept spinning after you hit the ocean bottom and couldn't go any further, and then you used the odometer to try to figure out how far up to go to get back to the surface, you might end up in midair somewhere. This is like that, except for threaded comment depth.

Best description ever.

Thanks so much for doing this!

[personal profile] swaldman 2014-07-13 06:10 am (UTC)(link)
Yes! That made me laugh loudly in the early morning! Fortunately housemate is away.
jordannamorgan: Claude Rains as Jack Griffin, "The Invisible Man". (Jack Griffin)

[personal profile] jordannamorgan 2014-07-14 04:40 am (UTC)(link)
I do not want that "modules" link showing up in my header, thanks. I'm perfectly capable of scrolling to the bottom of my screen by myself. Can you please tell me how to get rid of it? (Or make a way to do so, if there isn't one?)
liv: Stylised sheep with blue, purple, pink horizontal stripes, and teacup brand, dreams of Dreamwidth (sheeeep)

[personal profile] liv 2014-07-14 11:35 am (UTC)(link)
Hi there. Code tours aren't really the best place to make feature requests like this, but there's a post in [site community profile] dw_styles which explains how to hide the link.
jordannamorgan: The artwork "Ascending and Descending", by M. C. Escher. (Default)

[personal profile] jordannamorgan 2014-07-14 09:24 pm (UTC)(link)
Thanks. :)
libitina: snake across an open book (Default)

[personal profile] libitina 2014-07-14 06:00 pm (UTC)(link)
"Issue 723: Make navigation strip work for smaller screen sizes"

Weirdly, this seems to have made the navigation strip not work for my desktop computer. I'm just getting a thin dark stripe at the top, but none of the menu bits are visible. I tried hovering on the off chance it would expand, but no (but that's probably not news to you).

Screenshot

Meanwhile - that's a lot of stuff. Mostly tidying up behind the couch where I never look. You all rock.
libitina: snake across an open book (Default)

[personal profile] libitina 2014-07-14 07:53 pm (UTC)(link)
done. Thanks.