kaberett: A sleeping koalasheep (Avatar: the Last Airbender), with the dreamwidth logo above. (dreamkoalasheep)
kaberett ([personal profile] kaberett) wrote in [site community profile] dw_dev2014-04-06 03:09 pm
Entry tags:

Code tour for 24th November 2013-10th March 2014

All aboard the oh-gods-oh-gods-oh-gods we-haven't-done-one-of-these-since-November GET ON THE BUS.

Ordinarily, I would take you on a chronological tour, starting with the bugs touched longest ago and finishing with the most recent exciting work. Because of Reasons, this time we are instead playing the game of going from the bug that was reported longest ago to the one that was filed most recently. Spot the diiiiiifference. (Dear cataloguers of the future: the most recent bug in this lot is 2165, committed on 2014-03-10.)

Bug 468: /community/manage.bml is confusing with invitations and members
Category: Misc UI/Frontend
Patch by: [personal profile] fu, sort of
Description: Page titles for inviting users to communities were confusing and counter-intuitive. Fu fixed this one while getting bug 5265 sorted -- see later!

Bug 647: Replace talkread/talkpost with a S2 style that's wrapped in site scheme.
Category: S2 Backend
Patch by: [personal profile] exor674 & [personal profile] momijizukamori
Description: The DW codebase contains many Shambling Horrors of the Deep. Sometimes people trip up on them and get eaten. This is generally considered poor customer service. Consequently, intrepid devs took a months-long expedition, armed to the teeth, and I am delighted to report that they have returned victorious, with one more Horror if not slain, then at least incapacitated.

Bug 1386: make sure site schemes use different visited/unvisited link colors
Category: Site Layout/Navigation
Patch by: all the people
Description: Open since 2009, this bug has finally been shuffled off to bed - because at last it's pretty sure everything but obscure edge-cases have been dealt with. Thank you so much to everyone involved - people who have discussed, characterised, worked on, or otherwise touched this bug include: [personal profile] kareila, [personal profile] jeshyr, [personal profile] cesy, [personal profile] sophie, snakeling, [personal profile] yvi, [personal profile] chemicallace, [staff profile] denise, and [personal profile] ninetydegrees.

Bug 2165: Community posting options overhaul
Category: Communities
Suggested by: [staff profile] mark
Patch by: [personal profile] fu
Description: Posting options presented to community maintainers were confusing: "all members can post" and "select members can post" now do more intuitive things, and a new option - "new members can/cannot post" - has been introduced when the latter's selected.

Bug 2394: Community Management: merge /community/settings and /manage/settings/
Category: Misc UI/Frontend
Patch by: [personal profile] fu
Description: Also fixed as part of bug 5265 :-)

Bug 4073: Site search retains deleted content
Category: Search
Patch by: [personal profile] fu
Description: Site search should not retain deleted content. That it did was no good very bad. And now it doesn't! Which is... better.

Bug 4274: Community members list edit success: list pages
Category: Communities
Suggested by: [personal profile] azurelunatic
Patch by: [personal profile] fu
Description: A tweak to the code so that, when you save edits to community membership, you don't get dumped back on the first page, even if you saved edits on page 19 of 27 and wanted to just keep going!

Bug 4905: Clean up isS1 logic in jquery.threadexpander.js
Category: Modernization
Patch by: [personal profile] fu
Description: Killed dead with fire some obsolete code that was no longer required :-)

Bug 5091: Lefty: popup links display incorrectly because of some broad CSS
Category: Style System
Patch by: [personal profile] ninetydegrees
Description: A tiny CSS tweak to make the style Lefty display better. Does what it says on the tin.

Bug 5109: Support: keep closed reports available for 7 days
Category: Misc UI/Frontend
Patch by: [staff profile] denise
Description: A nice one for support volunteers: makes it easily possible to look at reports closed in the last 7 days, as opposed to just the last 24 hours.

Bug 5133: Master check-box for email notifications not working on Account Settings/Notifications
Category: Misc UI/Frontend
Patch by: [personal profile] hotlevel4
Description: Master check-boxes turning email notifs on/off weren't working: checking or unchecking the parent had no effect on the children. Some javascript tweaking later, and it's working!

Bug 5254: Importer gives up when it encounters ext_* with no name
Category: Importer
Patch by: [personal profile] fu
Description: If an OpenID account on an LJ-based site didn't have its "name" field set, the importer would fail. Now, instead, it falls back to using "ext_123.livejournal.com" as the name - so imports Should Just Work.

Bug 5265: Convert /community/*.bml to TT + Foundation
Category: Mondernization
Patch by: [personal profile] fu
Description: BML is another of the Shambling Horrors of the Deep. There is an ongoing effort to rip it all out by the roots and replace it with something that is, ah, a little more up-to-date. When bringing the community management page up to modern standards, Fu also fixed a couple of other outstanding design issues -- thanks, Fu!

Bug 5272: Crossroads: New Themes
Category: Style System
Themes by: [personal profile] forests_of_fire
Patch by: [personal profile] momijizukamori
Description: One new theme for the layout Crossroads!

Bug 5286: Increase contrast of gray text on Foundation pages
Category: Misc UI/Frontend
Patch by: [personal profile] hotlevel4
Description: Experiments are ongoing with having site-schemed pages based on the system Foundation. The contrast between text and background was too low here, which is an accessibility issue - but fixed, now!

Bug 5293: december points bonus
Category: Payments
Patch by: [personal profile] fu
Description: All points purchases in December get a 10% bonus. This was for that. :-)

Bug 5294: redirect /tools/recent_comments
Category: Site Layout/Navigation
Patch by: [personal profile] fu
Description: More BML was removed from the codebase. Our beneficent overbeings are, however, mostly beneficent, and they didn't want people's bookmarks to break -- so an automatic redirect to the new URL has been plonked at the old one, and everything should keep working seamlessly.

Bug 5296: |Migrate custom text properly
Category: Style System
Patch by: [profile] momijizukamore
Description: Bug 2366 was supposed to make migration of custom text when switching styles Just Work. Unfortunately, it didn't. Now, however, it should. Is the plan.

Bug 5298: Missing theme
Category: Style System
Patch by: [personal profile] ninetydegrees
Description: In actually uploading [profile] nornoriel's theme Aranel for Librarian's Dreams, the preview made it through but the actual theme, er, didn't. Should be available now!

Bug 5301: Community entries only have setting to get top-level replies
Category: Inbox/Notifications
Patch by: [personal profile] exor674
Description: It was briefly the case that you would only get top-level replies to posts you made in a community - i.e. if person B replied to your post, and person C replied to person B's comment, you would get a notification of B's comment but not of C's. It got caught pretty quickly, though!

Bug 5303: Whitelist criticalcommons.org embeds
Category: Journal contents
Patch by: [personal profile] hotlevel4
Description: criticalcommons.org is often used to host fanvids. In order for embeds to show up on DW, the site needed to be added to the whitelist for embeds. Vids away!

Bug 5307: Link to FAQ 103 from FAQ 91 broken
Category: User documentation
Patch by: [staff profile] denise
Description: When a FAQ tries to introduce you to another FAQ, it helps if it gives you the right contact information.

Bug 5314: Summertime: restore controlstrip gradient
Category: Style System
Patch by: [personal profile] ninetydegrees
Description: Past!90d apparently thought the controlstrip gradient was ugly in Summertime. Morerecent!90d disagreed, and restored it.

Bug 5329: Polls: clarify 'all' in 'who can vote?'
Category: User documentation
Patch by: [personal profile] ninetydegrees
Description: When choosing who could vote in a poll, "all" in fact meant "registered users" - so the language's been updated to reflect this.

Bug 5331: Remove font_base_size from Librarian's Dream themes
Category: Style System
Patch by: [personal profile] ninetydegrees
Description: Some themes forced a font size different from Dreamwidth's default of 1em. This is an accessibility issue - so where a different font_base_size was set, it's been stripped out across the board.

Bug 5333: Homepage Inbox doesn't respect cuts|Dreamwidth Development
Category: Inbox/Notifications
Patch by: [personal profile] fu
Description: Notifications of new posts were truncated after a few lines in the main inbox view, but cut text wasn't used as a trigger for this. Now it is!

Bug 5334: Explicitly mark required Hash::MultiValue version
Category: Misc Backend
Patch by: [personal profile] exor674
Description: Perl modules! Dreamwidth requires Hash::MultiValue version greater than 0.10 - so the code now says this explicitly, rather than risking things breaking and needing to dig around to work out why.

YOU'RE WELCOME.

And also: thank you all; you're great. <333
musyc: Text: Serpents upon my dirigible (Text: Serpents on dirigible)

[personal profile] musyc 2014-04-07 02:51 am (UTC)(link)
Our beneficent overbeings are, however, mostly beneficent

I love that 'mostly' in there. XD
denise: Image: Me, facing away from camera, on top of the Castel Sant'Angelo in Rome (Default)

[staff profile] denise 2014-04-07 02:56 am (UTC)(link)

I'm not bad, I'm just drawn that way.

misskat: A lemur trying to eat a lot of watermelon. lemur labeled as me, and the watermelon labeled as "everyone in this bar." (I love everyone in this bar)

[personal profile] misskat 2014-04-07 02:58 am (UTC)(link)
ia ia rahaeli fhtagn
musyc: Do you like coffee? Only with my oxygen. (Coffee: With oxygen)

[personal profile] musyc 2014-04-07 04:55 am (UTC)(link)
I thought we weren't allowed to summon rah!

Or is it that we're only allowed to summon rah if we have offerings?

And is slaying a code weasel an offering or a summoning?

NOOOOOOOOOO I HAVE NOT HAD A LOT OF CAFFEINE WHY DO YOU ASK.
denise: Image: Me, facing away from camera, on top of the Castel Sant'Angelo in Rome (Default)

[staff profile] denise 2014-04-07 06:28 am (UTC)(link)

please do not summon me out of the depths of darkness, it gives me a headache and it's so inconvenient when it interrupts things

but if you have to, slaying a code weasel is the only acceptable offering ;)

misskat: Dreamwidth is powered by *disco ball* (Dreamwidth is powered by Disco!)

[personal profile] misskat 2014-04-07 02:54 am (UTC)(link)
Aww, no docs bugs pulled through. Drat!
tinny: (chuck_nerd is the werd)

[personal profile] tinny 2014-04-26 07:00 pm (UTC)(link)
Thanks for this post! I had somehow feared DW had died or something, since I haven't gotten any dw_news posts in my inbox in... ummm... 21 weeks. O_o

Today, I finally went looking for newer info. The fact that bugs are still getting fixed is reassuring.
denise: Image: Me, facing away from camera, on top of the Castel Sant'Angelo in Rome (Default)

[staff profile] denise 2014-04-26 07:33 pm (UTC)(link)

That's on me, I have to sharply ration my typing because of RSI and the length of a news post + comment replies means not being able to do anything with my hands for about a week or so after. I haven't had the space in my schedule to budget for that kind of expenditure.

tinny: Sherlock's favourite pastime is watching John Watson (sherlock_cant stop watching)

[personal profile] tinny 2014-04-26 08:01 pm (UTC)(link)
I understand. I kind of remember that, but I didn't know it was still an acute issue.

I don't know, maybe I'm the only one who judged the state of DW by the news posts. It's the only way I keep the connection to you as the show-runners so-to-speak, and not hearing from you made me doubt that things are going fine.

For me, it's fine to check the dev comm for that kind of reassurance instead, but maybe delegating the news to someone else would be an idea? I see it as a way to keep connected to the user base, but I'm not sure how important it is to other people, or to you.