misskat: two minions from Despicable Me, getting into trouble (Minions)
MissKat ([personal profile] misskat) wrote in [site community profile] dw_dev2013-07-18 10:35 pm
Entry tags:

Code Tour World Tour: June 27-July 18

This evening in IRC, when [staff profile] mark told us all to buckle our seatbelts to prep for the code push, [personal profile] kareila asked if anyone had done a code tour. When we all realized that we were code-tour-less, [personal profile] kareila and [personal profile] momijizukamori were conscripted voluntold forced to positively thrilled to volunteer of their own free will with no coercion whatsoever to help get this one done quickly. Thank you, ladies!





Code Tour by [profile] momikizukamori, Styles Queen

Bug 5095: Ciel/Hot Chocolate and Marshmallows: page bkg and page link are identical
Category: Style System
Patch by: [personal profile] momijizukamori
Description: I accidentally made a layout with the same colors on top of each other. INVISIBLE LINKS. Now rectified.

Bug 5177: Add left margin to userpics in contextual popups
Category: Misc UI/Frontend
Patch by: [personal profile] ninetyd
Description: When userpics show up in the contextual hover menu, they weren't spacing out things correctly. This bug adds a left-hand margin to fix that.

Bug 5176: Wide Open: credits display incorrectly
Category: Style System
Patch by: [personal profile] ninetyd
Description: When we added the names of the active theme to the credit module, it broke some of the styling in Wide Open, making it less pretty. Now it's pretty again.

Bug 5179: Ciel: Entry footer and navigation module need more link props
Category: Style System
Patch by: [personal profile] momijizukamori
Description: So when I went to do bug 5095 it turned out that I now had invisible links somewhere else, because some sections were missing properties for the link colors.

Bug 5118: Angel Cake: interaction links are not readable
Category: Style System
Patch by: [personal profile] momijizukamori
Description: So that problem that Hot Chocolate and Marshmallows had? Angel Cake had it in a different spot. In all three versions. These links are so invisible it's like a superpower.

Bug 5178: Fix entry footer display on Strata
Category: Style System
Patch by: [personal profile] momijizukamori
Description: ...and yeah, fixing Angel Cake made a problem with Strata footer links apparant.

Bug 5184: Add core2 interaction link props to TR
Category: Style System
Patch by: [personal profile] momijizukamori
Description: But it's cool, because we had the properties that Strata and Ciel needed already in the core layout layer! We just hadn't implemented them in the default layout CSS. And yes, at this point, two bugs had turned into five. WE HAVE TO GO DEEPER. (but now it's fixed for all the default layouts, so that both sets of links in the footer can have fancy colors via the wizard, and they don't have to inherit from the entry links if you don't want.)

Bug 4151: Entry metadata not currently reorder-able/reposition-able
Category: S2 Backend
Patch by: dw-abhihimself
Description: The order of entry metadata (location, mood, music) isn't configurable, much to the chagrin of some users. This bug adds some extra CSS classes to items in the list, so they can be individually moved around with CSS!

Bug 5113: Remove talkread.bml/talkpost.bml
Category: Modernization
Patch by: [staff profile] mark
Description: We replaced the (old, awful) bml pages that generated site-schemed comment pages with sleek new S2 ones a codepush ago. The old pages were still hanging around in the code base though, so Mark killed them with fire (and by 'fire' I mean 'git pull requests').

Bug 4988: English-strip /search & maybe update "comments" string
Category: English-Stripping
Patch by: [personal profile] ninetyd
Description: The way a lot of the site works is like this: we have a template one place, and it has variables that point to text in another place. That way it's easy to change text on something without messing up the template, and if another project wants to, they can replace all the English text with a different language easily. /search had some hardcoded text, as well as some kind of vague explanations, so 90d pulled out the hardcoded text, and rewrote it to be clearer.

Bug 4980: On the system default footer for crossposts, make the word OpenID a link to information about OpenID
Category: Crossposter
Suggested by: [personal profile] algeh
Patch by: [personal profile] jeshyr
Description: When you crosspost to other sites, there's an option to disable comments on the remote site, and put in a footer telling people to comment on the DW entry with OpenID. Problem: not everyone knows what OpenID is! [personal profile] jeshyr updated the crossposter footer to include a link to our write-up on using OpenID.

Bug 5080: Duplicate entry detector for imported entries
Category: Importer
Patch by: [personal profile] fu
Description: The importer is a tetchy beast, particularly when the sites we allow import from change up their format. We were already doing our best to try and catch duplicate entries by marking their ID with a special 'imported' flag in the database when they were first imported, but some people were still winding up with duplicates. This adds an additional check based on some of the stuff in the entry itself - the timestamp and subject, specifically, to try and keep out duplicates. It also logs when it skips an entry because it thinks it's a duplicate based on the fuzzy matching, so we can troubleshoot if it starts rejecting non-duplicate entries.

Bug 4260: Automatically redirect .htm to .html
Category: Misc UI/Frontend
Suggested by: [personal profile] garden_hoe21
Patch by: [personal profile] kaberett
Description: Dreamwidth pages use .html as an extension, and if you you accidentally changed that to .htm or .HTML, you wound up on the 404 page instead of where you wanted to be. Now these silently redirect to the .html version.

Bug 5199: race condition in credit card charges
Category: Payments
Patch by: [personal profile] alierak
Description: There was a problem where if the code that processed shop transactions went too fast, a later bit of a code would come up and re-queue the job again. It wasn't actually running the charge through again (so nobody got double-charged) but it resulted in errors on the admin side, and some users not receiving what they had paid for. It has now been fixed to not re-queue jobs that finished.

Bug 4981: Add an "are you sure?" dialog to the ban user process
Category: Misc UI/Frontend
Suggested by: [personal profile] teaotter
Patch by: [personal profile] kaberett
Description: Before, because you can ban a user from the pop-up that comes from hovering on their icon/username, it was really really easy to misclick and ban someone you didn't mean to. Now a confirmation pop-up shows when you click 'ban user', just to make sure you want to ban them.




Code Tour by [personal profile] kareila, Dev Goddess Rockstar

Bug 5141: FAQ #262: mention custom text module must be enabled
Category: User documentation
Patch by: [staff profile] denise
Description: We have a FAQ that tells people they can put web counters in a Custom Text module on their journal, but neglected to mention that the module wouldn't show up unless the user enabled it! The FAQ has now been updated to fix that oversight.

Bug 5114: Antispam: when half of the most recently created 10 journals get busted for spam, fetch some more
Category: Misc UI/Frontend
Patch by: [staff profile] denise
Description: The stats page tries to show us the ten newest journals, but then filters out any suspended spammers! Now it looks for twenty journals and shows the newest available ten.

Bug 2062: investigate LJ::ExternalSite, remove?
Category: Misc Backend
Patch by: [staff profile] denise
Description: Old unused code gone!

Bug 5009: Antispam: user spam reports: show profile stats on report
Category: Misc UI/Frontend
Patch by: [staff profile] denise
Description: Update spam reports to include more stats from the reported user, so that spamfighters don't have to click around the site as much.

Bug 5153: FAQ for YouTube workaround
Category: User documentation
Patch by: [personal profile] misskat
Description: Added a new FAQ detailing workaround for getting YouTube embeds working. They were being cranky.

Bug 1874: See who's in a particular custom filter when posting
Category: Journal contents
Suggested by: [personal profile] sedge
Patch by: [personal profile] woggy
Description: This adds a thing to the new (beta) update page such that when you select a custom posting filter, you get a little... widget? ... thing showing you who is on the filter. Shiny!

Bug 4176: Support notifications should have the username in them
Category: Inbox/Notifications
Patch by: [personal profile] kaberett
Description: Kaberett is my hero forever for taking over my (Kareila's) abandoned work on this bug! Support volunteers who receive request notifications will now also see the name of the user who wrote the request or comment. (Note from Kat: ALSO MY HERO FOREVER.)

Bug 4907: iOS icon does not work for user-domain bookmarks
Category: Browser Issues
Patch by: [personal profile] dreamatdrew
Description: The main www.dreamwidth.org site has long had a thing where if you created a bookmark on an iOS device, it would have a shiny DW icon. This fix adds that bookmark icon to individual journals as well.

Bug 4758: Librarian's Dream: new themes
Category: Style System
Patch by: [personal profile] baggyeyes
Description: THEEEEEEEMES SO MANY THEEEEEEMES AS FAR AS I CAN SEEEEEEEEEEEEEEEEEEE. (7+6+9+5+5 = LOTS.)

Bug 4733: New Style: Mobility by branchandroot
Category: Style System
Patch by: [personal profile] liv
Description: New style! Mobility is designed to look good on mobile devices. Yay!

Bug 5163: ?skin=nonexistent-site-skin causes 500 error
Category: Misc Backend
Patch by: [personal profile] fu
Description: If you somehow obtained a URL ending in "?skin=something-weird" you would get an angry server error. Now we just use the default skin if we get a skin name we don't understand!

Bug 5154: Can't log out from entry page w/o comments in site skin
Category: Misc UI/Frontend
Patch by: [personal profile] fu
Description: This was a weird HTML form bug that only showed up in certain circumstances and would prevent people from logging out of the site. Since this is unfriendly behavior, we fixed it.

Bug 5149: Video Embeds from YouTube broken
Category: Journal contents
Patch by: [personal profile] shadowspar
Description: Those wacky YouTubers have started publishing links that don't even start with http! But we are on to them. They won't fool us that easily!

Bug 5152: not running texttool on a fresh install gives completely unhelpful warning
Category: Misc Backend
Patch by: [personal profile] fu
Description: Warnings should be helpful! Especially if you are trying to install things! Because that's frustrating enough as it is.

Bug 5165: FAQ 162 can be dequeued
Category: User documentation
Patch by: [personal profile] misskat
Description: We fixed a thing, so the FAQ explaining how the thing was broken is no longer needed! Yay!

Bug 5166: Dequeue FAQ 267
Category: User documentation
Patch by: [personal profile] misskat
Description: We fixed another thing, so the FAQ explaining how the other thing was broken is no longer needed! Yay!

Bug 5144: change canview:styles calls to siteadmin:styleview
Category: Site Administration
Patch by: [staff profile] denise
Description: Denise decided the site priv governing the ability to view other users' styles was in the wrong priv group, so she wrote a patch to rename it. Being the boss has its privileges! (ba dum ching)




Code Tour by [personal profile] misskat: Special Dre Edition! (Dre had a LOT of bugs this time around, so we broke them out into their VERY OWN SPECIAL SECTION!)

Bug 4759: subscribe to all comments notification not being inactivated when community time expires
Category: Inbox/Notifications
Patch by: [personal profile] exor674
Description: Members of premium paid communities can subscribe to a notification of all comments made in the community, on every entry. Previously, the code only checked once to make sure the community was paid up. If the community's paid time expired, the notifications would continue to be generated. This patch fixes that loophole.

Bug 5180: Non-numeric argument in feed merge UI
Category: Misc UI/Frontend
Patch by: [personal profile] exor674
Description: There was a bug in some code that forgot to make sure a list existed before asking how big it was. Since that doesn't work so well, Dre patched it up.

Bug 5183: Some feeds won't return data without Accept-Encoding: gzip
Category: Feeds
Patch by: [personal profile] exor674
Description: In certain circumstances, RSS feeds were refusing to send us their stuff unless we accepted compressed data. We weren't able to before, but we do now.

Bug 2291: Move /interface/xmlrpc into DW::Routing
Category: APIs: RPC/XML/Flat
Patch by: [personal profile] exor674
Description: We had a bunch of stuff which was special-cased for when someone tries to access the site. Instead of having a bunch of special snowflakes, a lot of this stuff got moved it to a different area that can handle them appropriately.

Bug 5171: Create custom XMLRPC/Soap::Lite transport that supports DW::Request
Category: Misc Backend
Patch by: [personal profile] exor674
Description: This is related to the bug above. The code that dealt with the special snowflakes needed to be modified to work with the area to which it was being moved so that it would work.

Bug 5170: Create centralized request cache
Category: Misc Backend
Patch by: [personal profile] exor674
Description: Let's say you ask Dreamwidth to give you your reading page. From the time you ask it until we give it to you is called the "request" (or at least that's the term for the duration of this bug.) There are a ton of separate variables which store data that's kept around the whole request. Having many places to remember to clear is getting unwieldy so this creates a single place for everything. It's like a nice, tidy closet now, rather than having all your stuff sprawled all over your house. Neat!

Bug 5197: Fix S2 compiler test suite
Category: S2 Backend
Patch by: [personal profile] exor674
Description: S2 is the stuff that makes Dreamwidth's styles system go chugga chugga. Dre has fixed up the test suite, so that when S2 is modified in other patches, the test suite can be run to make sure everything's working as it ought.

Bug 5161: remove codechecks for S2 comments beta
Category: Misc Backend
Patch by: [personal profile] exor674
Description: The new site scheme pages were in beta for a while, and there were checks for beta status in parts of the code. They've been removed now, as they're not in beta anymore!

Bug 5202: Rip out mysterious "page notices" code
Category: Misc Backend
Patch by: [personal profile] exor674
Description: There was some random code involving "page notices" that we don't use. The code machete was brought out, and those bits were carefully chopped out. With the code machete. Like one does.

Bug 110: Mod hat
Category: Misc UI/Frontend
Patch by: [personal profile] exor674
Description: This bug wins the award for the Oldest Bug Fixed This Code Tour! An administrator in a community generally also interacts with the community as a member. This allows admins to put on a "mod hat" when needed, to help differentiate between when they're acting in their Most Official Capacity, and when they're just another user.

A HUGE thank-you to all our contributors this time around! YAY OUR TEAM!

This has been your code tour. You may return to your regularly-scheduled Dreamwidth-y goodness. :)
kareila: (Default)

[personal profile] kareila([admin post] as admin) 2013-07-19 04:57 am (UTC)(link)
This is a test of the emergency Mod Hat system. This is only a test.
exor674: Computer Science is my girlfriend (Default)

[personal profile] exor674 2013-07-19 04:59 am (UTC)(link)
Haaaaaat!
azurelunatic: A glittery black pin badge with a blue holographic star in the middle. (Default)

[personal profile] azurelunatic 2013-07-19 05:43 am (UTC)(link)
HOLY FUCK THANK YOU DRE IT IS AWESOOOOOOOOOOOMMMMMMEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE
mark: A photo of Mark kneeling on top of the Taal Volcano in the Philippines. It was a long hike. (Default)

[staff profile] mark([admin post] as admin) 2013-07-19 05:12 am (UTC)(link)
Woah.
stormy: βͺ ππŽπ“πˆπ‚π„ ❫ 𝑫𝑢 𝑡𝑢𝑻 𝑻𝑨𝑲𝑬 𝑴𝒀 𝑰π‘ͺ𝑢𝑡𝑺 ⊘ (Default)

[personal profile] stormy 2013-07-19 05:41 am (UTC)(link)
So excited to finally see the mod hat being implemented!
revolutionary: (marceline β†’ me myself)

[personal profile] revolutionary 2013-07-19 05:44 am (UTC)(link)
oh my gosh, that's awesome! and kinda cute. mod hat powers!
musyc: Silver flute resting diagonally across sheet music (Default)

[personal profile] musyc 2013-07-19 05:46 am (UTC)(link)
Oooh, FANCY! I likes!
the_shoshanna: Dreamsheep holding a spork, w/ text "sheepSPORK" (sheepspork)

[personal profile] the_shoshanna 2013-07-19 10:46 am (UTC)(link)
The mod hat does not show up in my style (Sky for Crossroads); I had to reload this page in its original style (site scheme?) to figure out what y'all were squeeing about.
ninetydegrees: "Support Team, Mobilize!" & DW logo ala Batman (mobilize)

[personal profile] ninetydegrees 2013-07-19 12:21 pm (UTC)(link)
Oh the text is under the icon because it lacks a margin. I've just filed a bug so someone can fix it asap.
the_shoshanna: "I believe in Dreamwidth" colored pencils (Dreamwidth pencils)

[personal profile] the_shoshanna 2013-07-19 12:39 pm (UTC)(link)
Excellent, thanks!
momijizukamori: Green icon with white text - 'I do believe in phosphorylation! I do!' with a string of DNA basepairs on the bottom (Default)

[personal profile] momijizukamori 2013-07-19 05:12 am (UTC)(link)
Does this mean I get a crown? I want a crown.
zarhooie: Girl on a blueberry bramble looking happy. Text: Kat (Default)

[personal profile] zarhooie 2013-07-19 05:52 pm (UTC)(link)
Paid comm feature: option to select "crown" as default mod hat.
poulpette: A cup of coffee (full) with a crown above it. (TW - King Ianto's coffee)

[personal profile] poulpette 2013-07-19 07:23 pm (UTC)(link)
This is the only crown I have. You can have it :) *hands over crown, keeps the coffee*
momijizukamori: Shatterstar from the comic series X-Factor, looking very excited (Tony Stark Time)

[personal profile] momijizukamori 2013-07-19 07:24 pm (UTC)(link)

I don't actually like coffee so this arrangement works perfectly.

musyc: Bernard from Black Books (Black Books: Ludwig)

[personal profile] musyc 2013-07-19 05:44 am (UTC)(link)
Bug 4907: iOS icon does not work for user-domain bookmarks
Description: The main www.dreamwidth.org site has long had a thing where if you created a bookmark on an iOS device, it would have a shiny DW icon. This fix adds that bookmark icon to individual journals as well.



NOOOOOOOOOOOO! Y'all, I love you, I do, but this is......... it's very asdfgdasfgkeysmash. I set up different colors and layouts SPECIFICALLY so I know what journal I'm loading, and on a teeny tiny iPod screen the ability to hit the icon by color was WONDERFUL. A tiny snapshot of each layout, yay! But now does this mean that all those color/snapshot icons will be replaced by something identical? I'm really really unhappy that I might have seven identical icons to poke at. :((
mark: A photo of Mark kneeling on top of the Taal Volcano in the Philippines. It was a long hike. (Default)

[staff profile] mark 2013-07-19 06:24 am (UTC)(link)
Hmmm, you know, I didn't think of that use case when this was committed. We're talking about it some internally now and will figure out what to do, if we can make it work for this use case, or if we'll have to pull it out.

FWIW, right now it's not enabled (it requires a configuration change we missed, so it's not set up yet anyway). I'll leave it off for the time being while we discuss it.

Thanks for your feedback! It's really helpful to hear.
musyc: Draco facepalming (Draco: Facepalm)

[personal profile] musyc 2013-07-19 06:35 am (UTC)(link)
Heh, I thank you for calling it feedback rather than whinging. XD I was a little ashamed of myself, re-reading. I'm usually so impressed with everything about the site that something that breaks my usage actually came as a SHOCK. Afraid I let that Musyc respond. Sorry for being shouty-whingy, there.

If a use scenario like mine is enough of an outlier that it's not feasible to adjust for, I totally understand. Would still be frustrating, but understandable. :) I really do *heart* this site so much and I'm so glad y'all take everything you can into consideration. You're all fantastic people.
dreamatdrew: An orange leopard gecko half hiding behind the leaf of a 'lucky bamboo' plant, looking directly at you. (Default)

[personal profile] dreamatdrew 2013-07-19 04:59 pm (UTC)(link)
FTR: the whole reason I even called this a bug was that it was a behavior that everyone I asked thought was supposed to happen/already happening.
Idea: could make it (optionally?) use journal-default icon instead of swirly-d?
mark: A photo of Mark kneeling on top of the Taal Volcano in the Philippines. It was a long hike. (Default)

[staff profile] mark 2013-07-19 05:40 pm (UTC)(link)

I don't really want to make it an option.

Certainly when I saw this bug, I thought "oh yes, it 404s when the iPad requests the image on a subdomain, of course we should fix that!" Now, given user feedback, perhaps not. Maybe the 404 is the right thing.

My inclination is to say that we should leave it off on DW, but leave it as an option for other sites that might want to use it.

toasterchild: (<3)

[personal profile] toasterchild 2013-07-19 05:52 am (UTC)(link)
I don't know if I'm allowed/supposed to reply in this capacity, but I wanted to drop a note to say thank you very, very much for all of your hard work. Not only do you guys and gals, real people, keep this site running and continually work to improve it, but you communicate with a transparency and informative quality extremely rare in sites like these. Bravo and thank you.
pauamma: Cartooney crab holding drink (Default)

[personal profile] pauamma 2013-07-19 08:48 am (UTC)(link)
I don't think anyone will mind! :-)
sophie: A cartoon-like representation of a girl standing on a hill, with brown hair, blue eyes, a flowery top, and blue skirt. β˜€ (Default)

[personal profile] sophie 2013-07-23 10:13 pm (UTC)(link)
If you mean "allowed" as in you're not sure if Dreamwidth allow you to comment here, then you're more than welcome to comment here! Feedback is a really vital part of the process at DW and the devs here do listen. :)
havocthecat: the lady of shalott (Default)

[personal profile] havocthecat 2013-07-19 05:17 pm (UTC)(link)
I can use my Mod Hat powers in my comm now! Hooray!

Also, you all do the best code tours. They're perfect to liven up my Fridays.
phidari: A young girl reads from a book titled "Quantum Field Theory", her face somewhere between confusion and irritation. (let me get this straight)

[personal profile] phidari 2013-07-19 07:48 pm (UTC)(link)
Thanks!

Is there really no way to activate the "mod hat" unless you go to "more options", though? That's a bit inconvenient.
ninetydegrees: Drawing: a girl's face, with a yellow and green stripe over one eye (Default)

[personal profile] ninetydegrees 2013-07-19 08:06 pm (UTC)(link)
+1 for this. Should it go through suggestions?
ninetydegrees: Drawing: a girl's face, with a yellow and green stripe over one eye (flowers)

[personal profile] ninetydegrees 2013-07-19 09:41 pm (UTC)(link)
Thank you!
denise: Image: Me, facing away from camera, on top of the Castel Sant'Angelo in Rome (Default)

[staff profile] denise 2013-07-19 09:41 pm (UTC)(link)

Just a caveat that I am perpetually behind in letting stuff through, so your suggestion will be in the moderation queue for a bit. :)

phidari: (Default)

[personal profile] phidari 2013-07-19 09:45 pm (UTC)(link)
Ahaha, I figured it might be. (No offense, I totally know what that's like.) Thanks for the warning.
denise: Image: Me, facing away from camera, on top of the Castel Sant'Angelo in Rome (Default)

[staff profile] denise 2013-07-19 09:46 pm (UTC)(link)

There's always something that slips off the stack!