swaldman: A cute fluffy sheep curled up dreaming of Dreamwidth. Labelled "Simon: Bodger". (dw-dev)Simon ([personal profile] swaldman) wrote in [site community profile] dw_dev,
@ 2013-02-07 03:49 pm UTC
  • Previous Entry
  • Add to Memories
  • Tell someone about this!
  • Next Entry
Current mood: curious
The new feature that I've been working on (tweeting about new entries) is ready for initial code review. However, it is definitely not ready to be landed into develop yet. How should I request this review?

I haven't created a pull request, because it's not ready to land.
I can't flag it as needs-review on bugzilla, because there is no attachment - I could put it into an attachment, but I imagine that commenting on the commit on github is easier for all concerned...

Any ideas or preferences? :-)

(5 comments) - (Post a new comment)
(Flat) (Top-level comments only)

alierak: (default)


[personal profile] alierak
2013-02-07 05:51 pm UTC (link)
Not really a preference, but I can see one possible kludge: put the commit URL in a bugzilla attachment and flag that?

ETA: The thing is, I'm not sure if anyone is looking at that flag in Bugzilla anymore. Committers will definitely do code review before merging a pull request though.

Last edited 2013-02-07 05:54 pm UTC

(Reply to this)  (Thread) 


fu: Close-up of Fu, bringing a scoop of water to her mouth (fu)


[staff profile] fu
2013-02-08 02:06 am UTC (link)
Hmm, no I don't any longer. There's old stuff there that I need to clear out, but it's been taking a pretty low priority, and I'm not likely to notice any new things in there.

(Reply to this)  (Thread from start)  (Parent) 


mark: Photo of Mark's face, taken in standard office fluorescent. (me)


[staff profile] mark
2013-02-08 12:58 am UTC (link)
Do a pull request and just specify in it "this is not ready to land".

That is the review process. :)

(Reply to this)  (Thread) 


fu: Close-up of Fu, bringing a scoop of water to her mouth (fu)


[staff profile] fu
2013-02-08 02:05 am UTC (link)
Yup, agreed!

(Reply to this)  (Thread from start)  (Parent) 



[personal profile] swaldman
2013-02-08 11:33 am UTC (link)
OK!
Will do this later today :-)

(Reply to this)  (Thread from start)  (Parent) 


(5 comments) - (Post a new comment)
(Flat) (Top-level comments only)