dw_dev: Reminder: when making changes to Core2 check all styles please

Ninety Degrees (

ninetydegrees) wrote in

dw_dev,
@ 2012-09-30 04:22 pm UTC

Reminder: when making changes to Core2 check all styles please

If you make any change to Core2 --frontend but also backend, please check whether this also affects any of our official styles and open a bug for them if you don't want to update them as part of your own bug. It's the only way to make sure everything stays up-to-date and functional, and only requires a simple 'grep -ril'. :)

(4 comments) - (Post a new comment)
(Flat) (Top-level comments only)

	no subject swaldman 2012-10-01 08:36 am UTC (link)
	oops. looks sheepish hopes it wasn't him breaking something that prompted this ;-) (Reply to this) (Thread) (Hide 3 comments) (Show 3 comments)

	no subject momijizukamori 2012-10-01 02:30 pm UTC (link)
	If it makes you feel better I thought the same thing g 'Shit, did I do something?' (Reply to this) (Thread from start) (Parent) (Thread) (Hide 2 comments) (Show 2 comments)

	no subject swaldman 2012-10-01 03:16 pm UTC (link)
	grin well, it did make me look at a pull request that I had in and realise that I was about to break something (at least, fix something in core and leave Database behind). So the post was worthwhile! (Reply to this) (Thread from start) (Parent) (Thread) (Hide 1 comment) (Show 1 comment)

	no subject ninetydegrees 2012-10-01 05:02 pm UTC (link)
	Yeah, that was the spirit of my post! It's not so much about breaking things but about not leaving styles behind as you said. Any change related to S2 can potentially affect 40 styles and over 1,000 themes and tracking changes becomes much harder as time passes and they pile on. (Reply to this) (Thread from start) (Parent)

(4 comments) - (Post a new comment)
(Flat) (Top-level comments only)