denise: Image: Me, facing away from camera, on top of the Castel Sant'Angelo in Rome (Default)
Denise ([staff profile] denise) wrote in [site community profile] dw_dev2012-03-24 02:14 am
Entry tags:

Code tour: 14 Mar - 23 Mar

Behind the cut: 12 resolved bugs, all of which are now live (thanks to tonight's code push).



Bug 4366: (jquery beta) ajax "change your poll vote" doesn't work
Category: Journal contents
Patch by: [personal profile] fu
Description: This code tour will involve a lot of bugs fixing issues with the new JQuery beta, since [personal profile] fu spent this fortnight working towards the release candidate for that beta. This bug fixes an issue where changing your poll vote wasn't properly JQuerified -- it was loading a separate page rather than working inline.

Bug 4346: remove comments from icon alt/title text
Category: Icons
Patch by: [personal profile] deborah
Description: Last code push's changes to the hover text on icons included both the icon comments and the icon description in the hover text. Seeing it in action made us realize it probably shouldn't include the comments, so away they go; now it's just keyword and description. (This also fixes a problem with displaying the correct keywords when the icon was selected by it being the default icon.)

Bug 3401: Send errors on failed comment expansion
Category: Journal contents
Suggested by: [personal profile] azurelunatic
Patch by: [personal profile] allen
Description: Previously, if you tried to expand a comment (or a thread of comments) and something happened to prevent them from loading, any error message wouldn't be displayed; it would just silently fail. Now you get the error message!

Bug 4308: ThemeMetadata.pm actually defines package named StyleMetadata
Category: Misc Backend
Patch by: [personal profile] kareila
Description: This was an issue with a backend file being misnamed. It didn't cause any issues, because the package name was correct inside the file and correct every time it was called, but it's bad form to have the file named something different than the package it contains. So, this patch fixes it!

Bug 4347: /icons: persistent ?view=all and uploaded/keyword sort choices; add all link to top of page
Category: Icons
Patch by: [personal profile] fu
Description: Last code push we enabled pagination on the /icons page, in order to more easily view and manage large numbers of icons. This bug makes some tweaks to that system: a) it adds the "view all" link to the top of the page in addition to the bottom where it was already; b) it fixes a bug where the ?view=all would get lost if you toggled between uploaded and keyword sort order.

Bug 4337: CSS Standardization: add .inner to .header on Archive Page
Category: Style System
Patch by: [personal profile] ninetydegrees
Description: Adds some additional CSS classes to various places on the Archive page, by analogy with the same classes on entries and comments.

Bug 4340: CAPTCHA test suite fails on installations where captcha isn't set up
Category: Misc Backend
Patch by: [personal profile] kareila
Description: This backend fix corrects a problem where other sites running the DW code who have not set up the new "textcaptcha" antispam test would wind up failing tests.

Bug 3907: Brittle: new themes
Category: Style System
Patch by: [personal profile] ninetydegrees, themes by [personal profile] rising
Description: Oops! We'd thought we'd gotten all the themes attached to this bug in an earlier commit, but turns out we missed one. [personal profile] ninetydegrees to the rescue.

Bug 4342: more undefined string development warnings
Category: Misc Backend
Patch by: [personal profile] kareila
Description: This patch fixes a number of minor warnings in the site error logs -- none of them are things that cause problems, they're just technically errors that should be repaired to future-proof things, so they make noise to get noticed and fixed. Every now and then, [personal profile] kareila goes through and hushes them up.

Bug 4345: change priv for admin/capedit
Category: Site Administration
Patch by: [personal profile] foxfirefey
Description: This changes the "priv" (admin functions on the site run on certain privileges that site admins can grant to specific accounts) used to edit an account's capabilities (account type) in the admin areas. Previously, using that admin page required an account to have the most overarching super-usery priv there was, which made it impossible for site admins to grant access to that page to a more limited subset of people (without also handing them the keys to the kingdom).

Bug 4287: fix error in icon keyword mapping in comment imports (cgi-bin/DW/Worker/ContentImporter/Local/Comments.pm)
Category: Importer
Patch by: [staff profile] mark
Description: Mark, bless him, has spent the past two or three months guts-deep in the importer, fixing bugs and adding features. (I think he is utterly sick of that code by now.) This is a bugfix he did a little while ago -- we just forgot to close the bug. (It fixes a problem with icons getting the wrong keywords on import.)

Bug 4195: write a traffic cop for import jobs to shunt large jobs to the big new dbs
Category: Configuration
Patch by: [staff profile] mark
Description: When we were trying to figure out how to handle large import jobs (which suck up tons of memory), we were planning on shunting the really large ones onto the new database machines we added in January, which have loads and loads of memory to run in. Instead of mucking around with trying to pull out only the large jobs, though, we set it so that all the import jobs are running on those machines (and Mark busted ass to optimize the process, too).



As I mentioned, all of these fixes are live! You may need to opt in to the new Javascript on journals beta to see some of them. (Please do -- this is now the release candidate and we're trying to get as many eyeballs on it as possible.)
musyc: Silver flute resting diagonally across sheet music (Default)

[personal profile] musyc 2012-03-24 02:53 pm (UTC)(link)
Bug 4195: write a traffic cop for import jobs

DENISE, CAN THE TRAFFIC COP BE A MOUNTIE?

... Because reasons. It's like dear Benton becomes an unofficial mascot in these parts and it amuses me so.
silverflight8: bee on rose  (Bee)

[personal profile] silverflight8 2012-03-24 09:33 pm (UTC)(link)
Ah ha! The css that customizes cut text appearances now works correctly! :D
cesy: "Cesy" - An old-fashioned quill and ink (Default)

[personal profile] cesy 2012-03-31 05:36 am (UTC)(link)
It's so cool seeing all the little bits of optimisation and tidy-up fly by.
archangelbeth: An anthropomorphic feline face, with feathered wing ears, and glasses, in shades of gray. (Default)

[personal profile] archangelbeth 2012-04-12 10:07 pm (UTC)(link)
*admires the Descriptions hugely, as well as the work involved*

Thank you!