ilyena_sylph: IRL/stock car driver Danica Patrick in fire suit and with helmet, text of 'drives like a girl? hell, yes!'  (Racing: danica)
ilyena_sylph ([personal profile] ilyena_sylph) wrote in [site community profile] dw_dev2012-03-14 12:39 am
Entry tags:

Code tour (22 Feb - 13 March)

Hi y'all.

*waves* I have no idea what I'm doing here, (yeah I do, I told D I'd take distracting, this is how people get dragged into helping, isn't it? *waits for the chorus of 'Aye's*) ) but I'm gonna try and lead y'all through all the fun code fixes (and docs fixes!) everyone that actually does know what they're doing here accomplished recently.


Code bugs fixed

Bug 4336: Tabula Rasa: some links are out of order
Category: Style System
Patch by: [personal profile] ninetydegrees
Description: Fixed a bug in some mis-ordered CSS in Tabula Rasa that meant that once a user clicked 'the top of page link in the footer, they never again see the hover or active style on the link, only the visited style, which is a minor accessibility issue.' I had this problem, so I am so happy to see it fixed!

Bug 4220: CSS Structure: standardize the Tags Page to match other pages
Category: Style System
Patch by: [personal profile] ninetydegrees
Description: Fixed a bug in order to switch the tags page to the standard CSS structure. Also tweaked some affected CSS while at it, which just sounds like ever so much fun.

Bug 4228: Misc. Styles: new themes
Category: Style System
Patch by: [personal profile] ninetydegrees
Description: New themes! Several of them! Including:
New theme for Funky Circles by [personal profile] inoru_no_hoshi: Killjoys.
One theme by [personal profile] randomling (new theme contributor!): Sandbox.
Two themes by [personal profile] inoru_no_hoshi: Lichen, Killjoys.
Two new themes for Nouveau Oleanders by [personal profile] dancing_serpent: Lichtsturm; Eyeshadow and Lipstick.
Three themes for Crisped by [personal profile] timeasmymeasure: Eggplanted, Joy, Queries.

I am of the firm opinion that the people that make styles around here are some of the coolest people ever. Especially when they turn out multiples! So. If any of y'all are reading this, you are awesome.

Bug 4296: Sidebar overlaps content slightly in Skittlish Dreams tags and icons pages
Category: Style System
Patch by: [personal profile] fu
Description: Fixed a bug where the sidebar was overlapping content slightly in Skittlish Dreams on the tags and icons pages. Whoot!

Bug 4338: Link to view all icons
Category: Style System
Patch by: [personal profile] fu
Description: D had to make this one make sense to me, but apparently the 'view all icons' link wasn't showing up part of the time, and when it was it was only showing up at the bottom of the page. This fix dealt with the faulty logic there and made it so that the 'pagination'/'view all icons' links appear at both the top and bottom of the /icons page if there are more than six icons on the page. I went to poke at my own icons page, and that is going to make life so much nicer!

Bug 4339: unable to filter to icons with keywords/descriptions/comments containing parentheses
Category: Icons
Patch by: [personal profile] fu
Description: So the icon browser (which I never use) can apparently filter icons into subsets (text). It did this by looking at alt text, and in one of the various code fixes, all the alt text got parentheses. So if people were using parentheses inside their alt text, when they tried to filter to (text) they got all of their icons with alt text, because if the opening parenthesis. Fu fixed things so that that's not going to happen any more.

Bug 4341: Unable to create account: "too many codes" error, even though we've turned off invites
Category: Registration
Patch by: [personal profile] fu
Description: Fu broke it, so she fixed it. *waves at Fu, ducks!* I hear rumor that there's a commit-and-ditch pony floating around for this one? Something about breaking account creation for everyone?

Bug 4293: (jquery beta) bottom arrow doesn't jump you to the top of the cut tag when used to close the page
Category: Misc UI/Frontend
Patch by: [personal profile] fu
Description: This one is about the jQuery beta, which, as D pointed out to my exhausted self is happening "in order to improve accessibility, modernize the code, and make it easier to support in the future, we're replacing much of the custom-written javascript on the site with jQuery, which is a standard JavaScript library used by many different websites". So, it's going to do kind of a lot by the time they're done with it. In all the myriad site-navigation things in the jquery beta (which I'm personally having a blast with, seriously, so much fun), the bottom cut-tag expand arrow wasn't jumping the reader back to the top of the cut tag when it was used to close the cut again (not so much fun). But it's going to be all better now!

Bug 4295: (jquery beta - cut tag) .cuttag-open applied to a different element than non-beta
Category: Misc UI/Frontend
Patch by: [personal profile] fu
Description: ...okay, I think I understood this one all on my own. The border in the non jquery-beta that is applied to the arrows when they're used was doing something different in the jquery beta and putting a border around all of the expanded text, and now it's going to be fixed so that it only applies to the arrow again.

Bug 4069: In some situations, "Irreparable invalid markup" link uses invalid markup
Category: Misc UI/Frontend
Patch by: [personal profile] fu
Description: I stared at this one for a while, trying to figure out how to explain it, and then wailed to D. So, from D, "This corrects the HTML cleaner (the thing that identifies and blocks invalid HTML markup and strips malicious code) to make it more accurate when dealing with certain types of invalid markup". Which is going to be a good thing all around, because broken code is so ugly!

Bug 4365: (jquery beta) contextual hover menu fades even without user action
Category: Misc UI/Frontend
Patch by: [personal profile] fu
Description: I am so glad this one is fixed! It has been driving me more batty than usual (of course, given my life lately that's not surprising). In the jquery beta (fun as it's being), hovering over icons or usernames brings up the contextual hover menu just like it should, but then after a couple of seconds it fades out, even if the mouse hasn't been moved (or however else the hover menu was brought up). Now it will not fade out after being brought up until something else occurs (mouse moves, or whatever), and then it will fade. YAY!

Bug 3673: jQuerify inline entry tracking
Category: Misc UI/Frontend
Patch by: [personal profile] fu
Description: In one of the most awesome examples of concise summation I have ever seen, D says about this one that "this updates and modifies the javascript used for controlling entry and comment tracking to use jQuery, the more modern javascript library that DW is moving towards". So. Upwards and onwards!


Documentation bugs fixed


Bug 4232: FAQ #65 (Official communities) is missing some communities
Category: User documentation
Patch by: [personal profile] shadowspar
Description: FAQ #65 was fixed to include dw-meetups and dw-mobile, and some dead (or inaccessible to the general public) comms were removed.

Bug 4311: Basic intro to paid accounts
Category: User documentation
Patch by: [personal profile] inoru_no_hoshi
Description: What is a paid/premium paid/seed account? was written to be a basic introduction to paid accounts.

Bug 2679: Refactor Paid Account FAQs
Category: User documentation
Patch by: [personal profile] inoru_no_hoshi
Description: The paid account FAQ documentation was a little messy, now it is much cleaner! This piece of the fix involved the How much are paid accounts? FAQ, #153.

Bug 2929: FAQ #101 is missing links, has writer notes left in text
Category: User documentation
Patch by: [personal profile] bork
Description: FAQ #101 had some internal notes left in the text and was missing links, it has now been fixed.

Bug 3347: Update FAQs to reflect changes to "track all comments"
Category: User documentation
Patch by: [personal profile] chemicallace
Description: A couple of different FAQs were updated to better reflect changes to the "track all comments" feature.

Bug 4349: Network Page FAQ
Category: User documentation
Patch by: [personal profile] tyger
Description: FAQ 234 now exists to explain the Network Page!

Bug 4316: FAQ #71 needs clarifying
Category: User documentation
Patch by: [personal profile] rike_tikki_tavi
Description: FAQ #71 is now more clear about what notifications can and cannot be sent to a DW Inbox.

Bug 4319: Create icon browser FAQ
Category: User documentation
Patch by: [personal profile] inoru_no_hoshi
Description: FAQ #235 exists now, to explain the icon browser and how it works!

Bug 4208: FAQ #60 change: screened comments are visible to person you're replying to
Category: User documentation
Patch by: [personal profile] shadowspar
Description: FAQ #60 now explains screened comment and screened comment-replies in a little more detail.

Bug 4275: Open account creation period
Category: User documentation
Patch by: [personal profile] xdawnfirex
Description: FAQ #2 now explains how to create an account during an open account creation period.

Bug 4351: edit faq12 for invite-codes-off use case
Category: User documentation
Patch by: [staff profile] denise
Description: FAQ #12 now mentions that invite codes may not be required.

Bug 4353: more dinking around with faq4 (paid account benefits)
Category: User documentation
Patch by: [staff profile] denise
Description: More editing of FAQ #4 about paid account benefits.

Bug 4355: edit faq105 to reflect that invites are off
Category: User documentation
Patch by: [staff profile] denise
Description: FAQ #105 now explains why invite codes are off, and why they may come back.

Bug 4344: FAQ #87 needs to be updated to add some external sites
Category: User documentation
Patch by: [staff profile] denise
Description: FAQ #87 now has more external sites! (YAY!)

Bug 4213: OpenID users can join communities now
Category: User documentation
Patch by: [staff profile] denise
Description: the OpenID page now reflects that OpenID users can join communities.

Bug 4209: "Screened comment" text in UI needs to show that screened comments are visible to person you're replying to
Category: User documentation
Patch by: [staff profile] denise
Description: The screened comment UI now makes it more clear that if the comment is in reply to another user, that user will be able to see your reply.

Bug 4343: fix references to s.dreamwidth.org in FAQs
Category: User documentation
Patch by: [staff profile] denise
Description: A whole slew of FAQs that referred to URLS with bad code were fixed.

Bug 4356: change faq84 into "how do i claim my openid"
Category: User documentation
Patch by: [staff profile] denise
Description: FAQ #84 now explains how to claim an OpenID with a DW account.

Bug 4357: split faq137 into four FAQs
Category: User documentation
Patch by: [staff profile] denise
Description: The FAQ on the process of paying for an account, FAQ #137, was split into several smaller FAQs, namely FAQ #236, FAQ #237, and FAQ #238 in addition to the original.

Bug 4359: remove "current issues" FAQs that are no longer issues
Category: User documentation
Patch by: [staff profile] denise
Description: Several things that were problems, but aren't any more, were removed from the current issues FAQ page.

Bug 4352: decapitalization and style cleanup
Category: User documentation
Patch by: [staff profile] denise
Description: [staff profile] denise changed her mind about capitalization and fixed it (almost?) everywhere. How awesome is that?

Bug 4360: faq on inactive accounts/account trading
Category: User documentation
Patch by: [staff profile] denise
Description: FAQ #239 now exists as a one-stop reference for questions about inactive accounts and the practice of account trading.
fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)

[personal profile] fu 2012-03-14 06:18 am (UTC)(link)
Code tour \o/ Thank you! -- And I love all the docs bugs in this round!
musyc: Silver flute resting diagonally across sheet music (Default)

[personal profile] musyc 2012-03-14 09:37 pm (UTC)(link)
Yayyyyyyyyyyyy for updated FAQs! :D